This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 257237 - Kill running npm script on re-run
Summary: Kill running npm script on re-run
Status: VERIFIED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Tools (show other bugs)
Version: 8.2
Hardware: All All
: P2 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-21 08:46 UTC by Vladimir Riha
Modified: 2016-10-22 02:17 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2015-12-21 08:46:48 UTC 
I have a NPM script that starts some NodeJS server. If I run the script from IDE (NPM Scripts-> my script), it starts it OK. But when I need to re-run it, I must manually kill it (to free the server port) and start again. Would be nice if IDE would kill the running npm script if it has been invoked by use again (just like running NodeJS project works).

Thanks
Comment 1 Tomas Mysik 2016-01-04 08:24:43 UTC 
Sounds reasonable, thanks for reporting.
Comment 2 Tomas Mysik 2016-01-21 11:01:29 UTC 
Should be done now, please verify (together with re-run of project, please).

Thanks.

http://hg.netbeans.org/web-main/rev/41e2ad4b987d
Comment 3 Quality Engineering 2016-01-23 02:21:52 UTC 
Integrated into 'main-silver', will be available in build *201601230002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/41e2ad4b987d
User: Tomas Mysik <tmysik@netbeans.org>
Log: #257237 - Kill running npm script on re-run
Comment 4 Vladimir Riha 2016-02-10 15:17:41 UTC 
Thanks a lot :) Verified

Product Version: NetBeans IDE Dev (Build 201602100002)
Java: 1.8.0_45; Java HotSpot(TM) 64-Bit Server VM 25.45-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_45-b14
System: Linux version 3.16.0-30-generic running on amd64; UTF-8; en_US (nb)
Comment 5 Tomas Mysik 2016-10-21 07:12:10 UTC 
BTW this fix caused issue #268405.
Comment 6 Quality Engineering 2016-10-22 02:17:00 UTC 
Integrated into 'main-silver', will be available in build *201610220002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/87c1e08e9758
User: Tomas Mysik <tmysik@netbeans.org>
Log: #268405 - NullPointerException at org.netbeans.modules.javascript.nodejs.exec.NpmExecutable.stopRunningScript

Caused by fixing issue #257237.