This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 256183 - Test Results shows always fully red progress bar when some test fails
Summary: Test Results shows always fully red progress bar when some test fails
Status: REOPENED
Alias: None
Product: utilities
Classification: Unclassified
Component: Test Runner (show other bugs)
Version: 8.2
Hardware: PC Linux
: P3 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-26 14:46 UTC by Vladimir Riha
Modified: 2016-01-11 19:27 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (129.48 KB, image/png)
2015-10-26 14:46 UTC, Vladimir Riha
Details
IDE log (45.88 KB, text/plain)
2015-10-26 14:47 UTC, Vladimir Riha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2015-10-26 14:46:37 UTC
Created attachment 156977 [details]
screenshot

Reproduced with JSTestDriver, Mocha (both HTML5 project) and JUnit. If test results are e.g.: 1 passed, 1 failed, then the "progress" bar is entirely red while it should half red and half green. It is green if there are now failures. 



Product Version: NetBeans IDE 8.1 (Build 201510222201)
Java: 1.8.0_60; Java HotSpot(TM) 64-Bit Server VM 25.60-b23
Runtime: Java(TM) SE Runtime Environment 1.8.0_60-b27
System: Linux version 3.16.0-30-generic running on amd64; UTF-8; en_US (nb)
Comment 1 Vladimir Riha 2015-10-26 14:47:11 UTC
Created attachment 156978 [details]
IDE log
Comment 2 Theofanis Oikonomou 2015-10-26 15:12:38 UTC
This is as designed after fixing bug 250373. Now the logic is that 
1) if all tests pass -> bar is green 
2) if at least one test is aborted -> bar is (246, 232, 206) 
3) if at least one test is failed -> bar is red 
4) if at least one test is skipped -> bar is gray 

Also the text shows the % of passed tests. Thank you
Comment 3 Vladimir Riha 2015-10-26 15:28:34 UTC
Well I must say this is very "useless" change for me. The half green/half red was very useful fast indicator of "ration" between failed/passed, you don't have to read any number or expand any results. This way the progress kind of loses it's sense, it is not very useful to me.


Was there some discussion/"brainstorming" if the fix of #250373 is actually wanted or if it is more useful? I apologize if I sound a bit too harsh, but for me (albeit very subjective opinion) this is not a change for better :)
Comment 4 Vladimir Riha 2015-10-26 16:04:04 UTC
Lowering to further discussion :)
Comment 5 Theofanis Oikonomou 2015-10-27 09:10:04 UTC
(In reply to Vladimir Riha from comment #4)
> Lowering to further discussion :)

Thank you. Jirko any input on this? I guess we can discuss about this but it seems to me that it is a matter of preference and no functionality is lost. Both old and new behaviour have pros and cons.
Comment 6 Jiri Kovalsky 2015-10-27 09:40:52 UTC
As a reporter of issue #255188, I agree with Lada. In my opinion this should be customizable. I vote for introducing a new "Unit Testing" tab under "Tools > Options > Miscellaneous" which would contain this setting:

Color of status bar if for example 2 out of 5 tests fail:

  ( ) 100% green
  ( ) 40% red, 60% green
  (o) 100% red

Plus there could be a preview next to this setting showing how the status bar will look like listening on the radio button selection.
Comment 7 Theofanis Oikonomou 2015-10-27 09:56:05 UTC
(In reply to Jiri Kovalsky from comment #6)
> As a reporter of issue #255188, I agree with Lada. In my opinion this should
> be customizable. I vote for introducing a new "Unit Testing" tab under
> "Tools > Options > Miscellaneous" which would contain this setting:

Customization is good but IMO the question is: what we want this bar in TRW to stand for.

> 
> Color of status bar if for example 2 out of 5 tests fail:
> 
>   ( ) 100% green

this sounds unreasonable to me

>   ( ) 40% red, 60% green

this is the old behavior. This is problematic when for example user has 99 terst passing and 1 failing. The bar does not serve it's purpose of quickly show a visual indication of what the result of the test run was. You have to actually look at the text to see that the passing percentage is not 100%

>   (o) 100% red

this is the new behavior. User quickly sees that there is at least a failure in this test run.

IMHO user should do his best to have a green bar. Right? If the bar is not green he knows immediately there is a problem, i.e. there is an aborted/failed/skipped test case.
Comment 8 Jiri Kovalsky 2015-11-12 11:30:25 UTC
(In reply to Theofanis Oikonomou from comment #7)

> IMHO user should do his best to have a green bar. Right? If the bar is not
> green he knows immediately there is a problem, i.e. there is an
> aborted/failed/skipped test case.

Yes, but some people are fine with 99% pass rate and would appreciate having an option to see proportional colouring.