This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 25590 - A number of OpenIDE classes (e.g. SplittedPanel) get colors from java.awt.SystemColor, not UIManager
Summary: A number of OpenIDE classes (e.g. SplittedPanel) get colors from java.awt.Sys...
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: David Simonek
URL:
Keywords:
Depends on:
Blocks: 25472
  Show dependency tree
 
Reported: 2002-07-12 16:28 UTC by _ tboudreau
Modified: 2008-12-22 17:05 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Patch file (8.46 KB, patch)
2002-07-12 16:56 UTC, _ tboudreau 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2002-07-12 16:28:21 UTC 
I've been playing with theme support and noticed a
bunch of borders that did not seem to respond to
UIDefaults changes.
The reason is that they get their colors from
java.awt.SystemColor rather than using
javax.swing.UIManager.getColor().

Attaching a patch that replaces all of these calls
with calls
to UIManager.

BTW, there's reams of drawing code in some of
these classes that really should just be using
Swing borders.
Comment 1 _ tboudreau 2002-07-12 16:56:28 UTC 
Created attachment 6640 [details]
Patch file
Comment 2 Marek Grummich 2002-07-22 11:28:02 UTC 
Set target milestone to TBD
Comment 3 Marek Grummich 2002-07-22 11:29:48 UTC 
Set target milestone to TBD
Comment 4 David Simonek 2002-08-30 12:16:07 UTC 
patch integrated into main trunk.
Comment 5 Marian Mirilovic 2002-11-08 16:17:06 UTC 
verified in the source
Comment 6 David Simonek 2002-11-12 15:51:26 UTC 
Yes, this can go into 3.4.1
Comment 7 Jaroslav Tulach 2002-12-03 09:54:19 UTC 
Hi. This issue is marked as 3.4.1_CANDIDATE. It means that it should be
integrated into release341 one branch. The plan at
http://www.netbeans.org/devhome/docs/releases/34/index.html expected beta1 to be
produced on Dec01. That did not happen due to a lot of outstanding not
integrated candidates like this one. 

Would it be possible to spend few minutes by backporting this fix? Thank you in
advance.
Comment 8 David Simonek 2002-12-03 15:58:41 UTC 
few minutes = 2.5 hours :-), but finally integrated into release341
branch.
Comment 9 _ tboudreau 2002-12-03 17:10:47 UTC 
Yowch, was it that bad?

Dafe, you are a saint and I owe you several beers!
Comment 10 _ mihmax 2002-12-03 19:41:59 UTC 
2Dafe: thanks a lot, if I whenever come to Chech Republic, or you
visit Ukraine, I'll surely want to beering with you.

2Tim: reserve some beers, the reason: see above ;-)
Comment 11 David Simonek 2002-12-04 08:26:10 UTC 
:-) hahaha, thanks guys, no it wasn't bad or hard at all, just time
consuming - you know it - checkout the code, wait for tigris' locks,
take extra binaries from web, apply patches, compile using ant, ouch!
doesn't work, search why, checkout shapshot of extra bineries directly
from cvs, compile, hoorrray now it works, play a while with build to
ensure that something's not screwed up badly, try to commit, commit
fails, ok, another update, merge with changes other made during the
time, another compile, commit yes now it's ok, final update to ensure
that I didn't forget to commit some file, end of story :-)
I'm looking forward to further integrations if they will mean even
more beer offers :-)))
Comment 12 Quality Engineering 2003-07-01 16:12:25 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.