This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 255822 - Add examples for 'Group Multiline Alignment'
Summary: Add examples for 'Group Multiline Alignment'
Status: VERIFIED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Formatting & Indentation (show other bugs)
Version: 8.1
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-09 08:25 UTC by SebastianZ
Modified: 2016-08-19 02:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description SebastianZ 2015-10-09 08:25:55 UTC 
The options 'Assignment' and 'Array Initializer' at Tools > Options > Editor > Formatting > PHP > Alignment > Group Multiline Alignment are missing examples in the 'Preview:' field.
So it's not possible to see the effect of those options immediately.

Sebastian
Comment 1 SebastianZ 2015-10-09 08:47:56 UTC 
Also 'Implements List' is missing an example.

Sebastian
Comment 2 Tomas Mysik 2016-06-03 06:57:38 UTC 
Perhaps Junichi could be interested in this issue? It should be an easy fix IMHO.

Thanks.
Comment 3 Tomas Mysik 2016-08-15 08:05:46 UTC 
Anyone has some nice example? This is a great chance for a contribution :)
Comment 4 Tomas Mysik 2016-08-15 12:16:54 UTC 
Should be fixed now, feel free to verify this issue or provide better samples ;)

Thanks.

http://hg.netbeans.org/web-main/rev/365d45ae24f4
Comment 5 Quality Engineering 2016-08-16 02:51:46 UTC 
Integrated into 'main-silver', will be available in build *201608160002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/365d45ae24f4
User: Tomas Mysik <tmysik@netbeans.org>
Log: #255822 - Add examples for 'Group Multiline Alignment' and 'Multiline Alignment'
Comment 6 SebastianZ 2016-08-17 11:23:30 UTC 
The examples you added for visualizing the multiline alignment grouping looks ok to me. Thanks for that! You could have choosen a bit longer names, though, to make the effect more obvious.

But I am still missing examples for the 'Multiline Alignment' options as mentioned in the summary and comment 1, i.e. 'Method Parameters', 'Method Call Arguments' and 'Implements List'. Should I file a new bug for that?

Sebastian
Comment 7 Tomas Mysik 2016-08-17 11:36:41 UTC 
(In reply to SebastianZ from comment #6)
> But I am still missing examples for the 'Multiline Alignment' options as
> mentioned in the summary and comment 1, i.e. 'Method Parameters', 'Method
> Call Arguments' and 'Implements List'. Should I file a new bug for that?

Yes please. Feel free to provide some nice examples, if you want to.

Thanks.
Comment 8 SebastianZ 2016-08-17 12:21:36 UTC 
(In reply to Tomas Mysik from comment #7)
> (In reply to SebastianZ from comment #6)
> > But I am still missing examples for the 'Multiline Alignment' options as
> > mentioned in the summary and comment 1, i.e. 'Method Parameters', 'Method
> > Call Arguments' and 'Implements List'. Should I file a new bug for that?
> 
> Yes please. Feel free to provide some nice examples, if you want to.

Created bug 267617. I would have provided examples, though I didn't find out yet what the options actually do. :-) They don't seem to make any difference in formatting. I'll have a deeper look when I have more time the next days.

Sebastian
Comment 9 Tomas Mysik 2016-08-17 12:28:41 UTC 
(In reply to SebastianZ from comment #8)
> Created bug 267617.

Thanks!

> I would have provided examples, though I didn't find out
> yet what the options actually do. :-) They don't seem to make any difference
> in formatting. I'll have a deeper look when I have more time the next days.

I see :) I will try to find out what they do :)

Thanks.
Comment 10 Tomas Mysik 2016-08-18 06:48:44 UTC 
Better variable names.

http://hg.netbeans.org/web-main/rev/4d9e4afca34b
Comment 11 SebastianZ 2016-08-18 08:23:16 UTC 
(In reply to Tomas Mysik from comment #10)
> Better variable names.
> 
> http://hg.netbeans.org/web-main/rev/4d9e4afca34b

Great! Thank you!

Sebastian
Comment 12 Quality Engineering 2016-08-19 02:56:18 UTC 
Integrated into 'main-silver', will be available in build *201608190002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/4d9e4afca34b
User: Tomas Mysik <tmysik@netbeans.org>
Log: #255822 cont'd - Add examples for 'Group Multiline Alignment'

Better variable names.