This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 255180 - I18N: filter names are hardcoded
Summary: I18N: filter names are hardcoded
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 8.1
Hardware: All All
: P2 normal (vote)
Assignee: Masaki Katakai
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2015-09-10 13:23 UTC by Masaki Katakai
Modified: 2015-09-12 09:19 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
screenshot (16.75 KB, image/png)
2015-09-12 09:18 UTC, Masaki Katakai 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2015-09-10 13:23:47 UTC 
It seems that all filter names defined in 

./refactoring.java/src/org/netbeans/modules/refactoring/java/plugins/JavaWhereUsedQueryPlugin.java

are hardcoded as below,

        filtersDescription.addFilter(JavaWhereUsedFilters.ReadWrite.READ.getKey(), "Read filter", true,
        filtersDescription.addFilter(JavaWhereUsedFilters.ReadWrite.WRITE.getKey(), "Write filter", true,
        filtersDescription.addFilter(JavaWhereUsedFilters.ReadWrite.READ_WRITE.getKey(), "Read/Write filter", true,
        filtersDescription.addFilter(JavaWhereUsedFilters.IMPORT.getKey(), "Import filter", true,
        filtersDescription.addFilter(JavaWhereUsedFilters.COMMENT.getKey(), "Comment filter", true,
        filtersDescription.addFilter(JavaWhereUsedFilters.SOURCEFILE.getKey(), "Source filter", true,
            filtersDescription.addFilter(JavaWhereUsedFilters.BINARYFILE.getKey(), "Binary filter", true,
        filtersDescription.addFilter(JavaWhereUsedFilters.TESTFILE.getKey(), "Test filter", true,
            filtersDescription.addFilter(JavaWhereUsedFilters.DEPENDENCY.getKey(), "Dependency filter", true,
            filtersDescription.addFilter(JavaWhereUsedFilters.PLATFORM.getKey(), "Platform filter", true,

Please extract

 "Read filter"
 "Write filter"
 "Read/Write filter"
 "Import filter"
 "Comment filter"
 "Source filter"
 "Binary filter"
 "Test filter"
 "Dependency filter"
 "Platform filter"

to Bundle.properties so that they can be localized.
Comment 1 Ralph Ruijs 2015-09-11 10:04:53 UTC 
changeset:   138026d8f95c
user:        Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
date:        Fri Sep 11 12:04:02 2015 +0200
summary:     #255180 - I18N: filter names are hardcoded
Comment 2 Quality Engineering 2015-09-12 03:06:15 UTC 
Integrated into 'main-silver', will be available in build *201509120002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/138026d8f95c
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: #255180 - I18N: filter names are hardcoded
Comment 3 Masaki Katakai 2015-09-12 09:18:48 UTC 
Created attachment 156121 [details]
screenshot

Product Version: NetBeans IDE Dev (Build 201509120002)

Now all filter names come from Bundle.properties.
Comment 4 Masaki Katakai 2015-09-12 09:19:28 UTC 
marked as VERIFIED. Thank you!