This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 254556 - Filtering out problems in folder filters out only current file
Summary: Filtering out problems in folder filters out only current file
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Parsing & Indexing (show other bugs)
Version: 8.1
Hardware: PC Linux
: P1 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords: 81_HR_FIX
Depends on:
Blocks:
 
Reported: 2015-08-20 12:22 UTC by Vladimir Riha
Modified: 2015-10-14 15:00 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2015-08-20 12:22:46 UTC
Please have 2 css files in a folder in site root of HTML5 project. Make some syntax errors in both css files and then enable filtering out problems in given folder

=> only the current file has no error badge, the 2nd file still has an error badge and even IDE restart won't help

Thank you


Product Version: NetBeans IDE Dev (Build 201508200002)
Java: 1.8.0_60; Java HotSpot(TM) 64-Bit Server VM 25.60-b23
Runtime: Java(TM) SE Runtime Environment 1.8.0_60-b27
System: Linux version 3.16.0-30-generic running on amd64; UTF-8; en_US (nb)
Comment 1 Milutin Kristofic 2015-08-25 14:05:05 UTC
Reproducible. It is because errors are cached. If file was not changed, restart will not help. 

I am not sure how to fix this. I cannot reparse everything because of errors filtering. Css is only reparse/reindexing file you fired filtering.
Comment 2 Milutin Kristofic 2015-09-28 12:23:15 UTC
I understand that this issue is making filtering problems a little useless. Still it filters files in new css files, in modified css files. 

I can reparse all CSS files under the project, however this can introduce performance issues. I would rather do this change in beginning of development for next version than in the end of development of 8.1


Therefore I am requesting waiver for this issue, so this issue will not stop NB 8.1. I promise this will be one of the first issue I will work on next NB version.
Comment 3 Vladimir Riha 2015-09-29 12:31:31 UTC
Honestly, I'm not sure about this not being fixed in 8.1. If I remember correctly it was fixed in bug 141181 and even released in patch. 

The workaround is fine for user files, but imagine a situation when using some framework with css files that are either invalid (but OK for given framework) or which are showing some bug in CSS editor. It is not very convenient to re-save every single file...

I thought even in previous versions turning off/on filtering errors triggered some reparsing (or at least IDE showed "background scanning"). I imagine users would be more willing to sacrifice some performance (especially when it happens just on demand and typically not too often) rather than seeing error badges (or re-saving every affected css file manually)
Comment 4 Milutin Kristofic 2015-10-07 11:50:12 UTC
CSS code is refreshing all roots in all projects when you enable error filtering. However it seems that this method is not doing same as it was in 7.4. I have workaround, that I refresh only current project root, that this works for files in HTML5 project (only in one).


Tomas is currently looking on the issue, and maybe he will come with fix. Otherwise I will submit workaround to 8.1.
Comment 5 Tomas Zezula 2015-10-08 11:26:15 UTC
It's a server_split regression.
Comment 6 Tomas Zezula 2015-10-08 12:01:01 UTC
Fixed jet-main 8cdc61d77c62
Comment 7 Tomas Zezula 2015-10-08 12:12:06 UTC
Vlado, can you test the fix when it will be available in daily build?
Thanks
Comment 8 Vladimir Riha 2015-10-08 12:27:13 UTC
Of course, will do. Thanks
Comment 9 Jiri Kovalsky 2015-10-08 13:38:15 UTC
Raising to P1 in order to get the fix to release81 branch. Thanks Tomasi!
Comment 10 Quality Engineering 2015-10-09 01:22:10 UTC
Integrated into 'main-silver', will be available in build *201510090002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/8cdc61d77c62
User: Tomas Zezula <tzezula@netbeans.org>
Log: #254556:Filtering out problems in folder filters out only current file
Comment 11 Vladimir Riha 2015-10-09 11:32:08 UTC
Verified in trunk

Product Version: NetBeans IDE Dev (Build 201510090002)
Java: 1.8.0_40; Java HotSpot(TM) Client VM 25.40-b25
Runtime: Java(TM) SE Runtime Environment 1.8.0_40-b25
System: Linux version 3.13.0-35-generic running on i386; UTF-8; en_US (nb)
Comment 12 Jiri Kovalsky 2015-10-12 08:33:03 UTC
Tomasi, please backport the fix to release81 branch. Thanks.
Comment 13 Tomas Zezula 2015-10-12 10:57:36 UTC
Transplanted into release81 2bdd6e7fc4c8
Comment 14 Vladimir Riha 2015-10-14 15:00:03 UTC
Verified in RC2

Product Version: NetBeans IDE 8.1 RC2 (Build 201510122201)
Java: 1.8.0_45; Java HotSpot(TM) 64-Bit Server VM 25.45-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_45-b14
System: Linux version 3.16.0-30-generic running on amd64; UTF-8; en_US (nb)