This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Link: http://services.netbeans.org/synergy/client/app/#/case/4989/suite/1691 Product Version: NetBeans IDE Dev (Build 201507240001) Java: 1.8.0_51; Java HotSpot(TM) 64-Bit Server VM 25.51-b03 Runtime: Java(TM) SE Runtime Environment 1.8.0_51-b16 System: Windows 8 version 6.2 running on amd64; UTF-8; pl_PL (nb) public class CreateSubclass // HINT: Create subclass { private class PrivateClass // "Create subclass" hint should NOT appear here, as the class has private access and "Create subclass" only creates top-level subclasses. { } } The comment clearly states that the hint shouldn't appear here, but it does, and invoking it leads to creating a class with an error: public class PrivateClassImpl extends CreateSubclass.PrivateClass { } The error is "CreateSubclass.PrivateClass has private access in CreateSubclass".
Same here: public class ClassWithPrivateConstruction // "Create subclass" hint should NOT appear here, as the class has private access and "Create subclass" only creates top-level subclasses. { private ClassWithPrivateConstruction() { } }
I think the suggestion SHOULD appear even in this case, to incremental aid refactoring. It's a inline suggestion (rather an intention), which does not appear in code inspection and the user chooses when to execute the action at will. We should not demand a specific workflow: that the user first turns the class to protected or public (possibly changing constructors) and only THEN the IDE can assist in generating the boilerplate code. Please update the test spec. If unhappy with the decision, raise a discussion on mailing list.
Integrated into 'main-silver', will be available in build *201508050002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/4891cee42d1a User: Svata Dedic <sdedic@netbeans.org> Log: #253838: create subclass suppressed on non-static types