This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 25364 - Netbeans 3.4 Beta 2 CVS External Client does not Refresh correctly
Summary: Netbeans 3.4 Beta 2 CVS External Client does not Refresh correctly
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
: 25543 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-07-04 13:56 UTC by Ron Cordell
Modified: 2003-07-01 12:58 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Cordell 2002-07-04 13:56:57 UTC
NB3.4Beta2, JDK1.4.0_01
I've set the external CVS properties to make sure
that the Refresh occurs when the directory is
opened, but the files are not being refreshed
properly. If a direcotry is opened that contains
sub-directories as well as source files, the
source files in that directory don't get
refreshed. The refresh occurs if I manually
refresh those files, however. Also, the folders
themselves always 
show "Local" instead of the CVS version
information unless a checkout is done on that folder.
Comment 1 Jiri Kovalsky 2002-07-10 09:47:06 UTC
Module vcscvs is no longer in NetBeans 3.4 therefore reassigning
component. I must say that I've seen things like that too but can't
reliably reproduce. :-(
Comment 2 Jiri Kovalsky 2002-07-12 16:31:22 UTC
*** Issue 25543 has been marked as a duplicate of this issue. ***
Comment 3 Martin Entlicher 2002-07-20 16:18:33 UTC
Any reproducible steps are needed. If this happens, please attach the
content of CVS/netbeans.cmd.cache files located in parents of [Local]
folders. Please mention also what did you do *before* this happened.
Changing priority to P4 - manual refresh should always repair this.
Comment 4 Jiri Kovalsky 2002-07-22 16:50:53 UTC
I think this should also be mentioned in the Release Notes of NetBeans
3.4. There are still some problems with incorrect status refreshing.
Comment 5 Patrick Keegan 2002-07-29 23:12:44 UTC
Does this just happen with genericvcs? Or does it also happen with 
javacvs? In what kinds of situations does the problem occur?
Comment 6 Ron Cordell 2002-08-04 15:52:41 UTC
 At first I thought that this issue only occurred with the external 
CVS client, but now I have seen it happen with the javacvs as well. 
I am unable to test with the generic cvs client. 
Comment 7 Jiri Kovalsky 2002-08-05 08:34:47 UTC
In such case this belongs to vcscore component.
Comment 8 Patrick Keegan 2002-08-08 22:05:36 UTC
proposed release note: 

The automatic refresh of file status in version-controlled 
filesystems does not work correctly. Even if the Auto Refresh 
property for a filesystem is set to refresh files when a folder is 
opened, source files in that directory do not get refreshed (though 
files in subdirectories do get refreshed). 

Workaround: Manually refresh the folder using the either the 
Refresh or the Refresh Recursively command from the folder's submenu.
Comment 9 Jiri Kovalsky 2002-08-09 09:58:48 UTC
I like it too, what do you think Martin ? It would always be a bit vague.
Comment 10 Martin Entlicher 2002-08-09 18:32:51 UTC
Yes, it's good. It's important to mention that the workaround is to
refresh the files manually.

I'm not able to tell you the cause, I do not have reproducible steps.
It happens quite rarely to me.
Comment 11 Patrick Keegan 2002-08-09 18:58:26 UTC
Just to make sure: It's OK the way I stated it? Or does the user have 
to select the files individually before calling the Refresh command?
Comment 12 Martin Entlicher 2002-08-09 19:04:46 UTC
Yes, it's O.K. the way you said it. Sorry for the confusion when I
used the word "files", when I meant "refresh the files in the folder".
The user would run the refresh on the affected folder of course.
Comment 13 Martin Entlicher 2002-09-05 14:46:23 UTC
I'm increasing the priority to P3, since users are complaining about
this on nbusers. Also if the fix will be available, it's a candidate
for a 3.4.1 release if there will be any.
Comment 14 Martin Entlicher 2002-09-19 09:50:30 UTC
I'm starting to explore the problem...
Comment 15 Martin Entlicher 2002-09-26 09:57:10 UTC
Fixed in the main trunk.
It's necessary to perform a recursive refresh to repair the disk
cache, that can be in an inconsistent state. After the disk cache is
repaired, it should stay consistent and statuses should be refreshed
as expected.


Checking in
vcscore/src/org/netbeans/modules/vcscore/cache/CacheDir.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/cache/CacheDir.java,v 
<--  CacheDir.java
new revision: 1.29; previous revision: 1.28
done
Checking in
vcscore/src/org/netbeans/modules/vcscore/cache/CacheFile.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/cache/CacheFile.java,v 
<--  CacheFile.java
new revision: 1.9; previous revision: 1.8
done
Processing log script arguments...
More commits to come...
Checking in
vcscore/src/org/netbeans/modules/vcscore/caching/VcsCache.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCache.java,v 
<--  VcsCache.java
new revision: 1.47; previous revision: 1.46
done
Checking in
vcscore/src/org/netbeans/modules/vcscore/caching/VcsCacheDir.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCacheDir.java,v 
<--  VcsCacheDir.java
new revision: 1.39; previous revision: 1.38
done
Checking in
vcscore/src/org/netbeans/modules/vcscore/caching/VcsCacheFile.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCacheFile.java,v 
<--  VcsCacheFile.java
new revision: 1.10; previous revision: 1.9
done
Checking in
vcscore/src/org/netbeans/modules/vcscore/caching/VcsFSCache.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsFSCache.java,v 
<--  VcsFSCache.java
new revision: 1.32; previous revision: 1.31
done
Processing log script arguments...
More commits to come...
Checking in
javacvs/src/org/netbeans/modules/javacvs/caching/CvsCacheDir.java;
/cvs/javacvs/src/org/netbeans/modules/javacvs/caching/CvsCacheDir.java,v 
<--  CvsCacheDir.java
new revision: 1.27; previous revision: 1.26
done
Checking in
javacvs/src/org/netbeans/modules/javacvs/caching/CvsCacheFile.java;
/cvs/javacvs/src/org/netbeans/modules/javacvs/caching/CvsCacheFile.java,v 
<--  CvsCacheFile.java
new revision: 1.15; previous revision: 1.14
done
Comment 16 _ mihmax 2002-11-05 08:48:20 UTC
Accepted for 3.4.1

Sincere, Maxym
Comment 17 _ mihmax 2002-11-05 08:53:55 UTC
Martin, can you, please, QA this somehow?
Comment 18 Jiri Kovalsky 2002-11-05 09:00:12 UTC
Okay, I'm gonna verify it soon Max.
Comment 19 Martin Entlicher 2002-11-05 09:23:53 UTC
Well, this can be a problematic integration. This was a big change and
I remember, that I've had to do some small touchups later.
But definitely this bug is annoying and should be fixed in 3.4.1 IMHO.

I would like to ask our QA (Jirka & Dan) to test the cache
functionality really deeply in dev builds and report any problems.
We could then merge the cache impl. from main trunk to 3.4.1 branch.
Thanks.

Comment 20 _ mihmax 2002-11-05 09:35:58 UTC
Well, this is really annoying, I agree.
So you say that that's not only changes needed to fix this issue,
(your comment on 2002-09-26 01:57 PDT)?
Comment 21 Martin Entlicher 2002-11-05 10:29:56 UTC
> So you say that that's not only changes needed to fix this issue,
> (your comment on 2002-09-26 01:57 PDT)?

Yes. Some of them are additional fixes of reported bugs (e.g. issue
#27890), there is fixed one NPE, that was not reported and in addition
to this there is one performance fix, that can not be applied to 3.4.1
- issue #27239.

Thus I suppose, that we merge the changes reported here (comment on
2002-09-26 01:57 PDT) and then I'll manually merge additional fixes,
that are applicable (probably all except issue #27239). This should
not be a problem from QA point of view, since #27239 does not have any
affect on functionality.
Is that O.K.?
Comment 22 _ mihmax 2002-11-05 10:56:36 UTC
Yes, OK, I'll contact you, when the branch release341 is prepared
(tagged from release34 branch).
Comment 23 Martin Entlicher 2002-11-12 15:03:04 UTC
Maxym, we use Target Milestone to denote the version in which is the
fix actually committed. So you should set the Target Milestone to
3.4.1 *after* it's committed to release341 branch. Otherwise it would
break the queries and it will be considered as already fixed in 3.4.1
while it is not yet.

So, if you don't mind, I'm changing the TM back to 4.0, we should
change it to 3.4.1 as soon as it's fixed there. Thanks.
Comment 24 _ mihmax 2002-11-12 15:15:12 UTC
Sorry, 
I think we surely need some "HOWTO work with IssueZilla (for naive
Project Owners)" ;-)
Comment 25 Jiri Kovalsky 2002-11-14 10:19:53 UTC
Well, this bug is very hard to verify but I agree that cache is more
stable now. Problems that I discovered were usually of incorrect
parser behaviour so I am verifying this issue in development build
#200211140100 of NetBeans 4.0 and recommend it for NetBeans 3.4.1 release.
Comment 26 Jaroslav Tulach 2002-12-03 09:53:44 UTC
Hi. This issue is marked as 3.4.1_CANDIDATE. It means that it should be
integrated into release341 one branch. The plan at
http://www.netbeans.org/devhome/docs/releases/34/index.html expected beta1 to be
produced on Dec01. That did not happen due to a lot of outstanding not
integrated candidates like this one. 

Would it be possible to spend few minutes by backporting this fix? Thank you in
advance.
Comment 27 tkellerer 2002-12-03 14:15:25 UTC
I have tried the last two 3.4.1 dev builds. The one from 28 Nov seemed
pretty good in this regard. The one from 2nd Dec seems to be worse.
After starting NetBeans some folders and their contents are reported
as [Local] even though they are not. A CVS Update does fix this. I
have the impression (though not really verified it with testing) that
this has happens when the initial display in the explorer is the
project tab. The links to directories do not seem to behave correctly
here (some of them disable the "Refresh" item, although that should be
there all the times)
Comment 28 tkellerer 2002-12-04 14:34:08 UTC
The 3.4.1 dev build from 3.12. is far better now. It seems that the
cache needs some "tune-in-time" :-) After I deleted all NB-CVS cache
files and restarted it seems quite OK. 

I have been working with that build the whole day now, and have only
once seen a wrong version display (but that was right after the first
start after installing the build).

But I do see situations where the title in the source editor's tab is
not updated (i.e. when I commit, the tab text doesn't switch to the
correct annotation).
Comment 29 Martin Entlicher 2002-12-05 17:34:30 UTC
Merged into release341 branch.

/cvs/vcscore/src/org/netbeans/modules/vcscore/cache/CacheDir.java,v 
<--  CacheDir.java
new revision: 1.27.8.1.4.1; previous revision: 1.27.8.1
/cvs/vcscore/src/org/netbeans/modules/vcscore/cache/CacheFile.java,v 
<--  CacheFile.java
new revision: 1.8.28.1; previous revision: 1.8
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCache.java,v 
<--  VcsCache.java
new revision: 1.46.28.1; previous revision: 1.46
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCacheDir.java,v 
<--  VcsCacheDir.java
new revision: 1.38.28.1; previous revision: 1.38
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCacheFile.java,v 
<--  VcsCacheFile.java
new revision: 1.9.28.1; previous revision: 1.9
/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsFSCache.java,v 
<--  VcsFSCache.java
new revision: 1.31.30.1; previous revision: 1.31
/cvs/javacvs/src/org/netbeans/modules/javacvs/caching/CvsCacheDir.java,v 
<--  CvsCacheDir.java
new revision: 1.26.28.1; previous revision: 1.26
/cvs/javacvs/src/org/netbeans/modules/javacvs/caching/CvsCacheFile.java,v 
<--  CvsCacheFile.java
new revision: 1.14.34.1; previous revision: 1.14


Thomas, thanks for your tests, now the cache functionality in 3.4.1
should be stable.
Comment 30 Patrick Keegan 2003-03-04 00:11:47 UTC
removing RELNOTE keyword since this was fixed for 3.41
Comment 31 Quality Engineering 2003-07-01 12:58:04 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.