This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 250863 - editor.settings.storage module split
Summary: editor.settings.storage module split
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Options (show other bugs)
Version: 8.1
Hardware: PC Linux
: P1 normal (vote)
Assignee: Svata Dedic
URL:
Keywords: API, API_REVIEW_FAST
Depends on: 250873
Blocks:
  Show dependency tree
 
Reported: 2015-03-03 12:08 UTC by Svata Dedic
Modified: 2015-03-07 08:41 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Proposed changes (75.59 KB, patch)
2015-03-03 12:08 UTC, Svata Dedic
Details | Diff
Corrected patch; added missing file. (83.80 KB, patch)
2015-03-03 12:22 UTC, Svata Dedic
Details | Diff
Updated patch (120.53 KB, patch)
2015-03-05 10:09 UTC, Svata Dedic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Svata Dedic 2015-03-03 12:08:27 UTC
Created attachment 152357 [details]
Proposed changes

The editor settings storage contains parts which are related to some specific settings and parts which serves as an infrastructure for these settings.

I would like to reuse the infrastructure outside of desktop NetBeans, so I would like to propose the module split into editor.settings.storage used in NetBeans and editor.settings.lib (infrastructure) library used by .storage.

No semantic or API change, except that several packages are split between the two modules. There's an implementation dependency between the two modules to suppress a need for broad API.

Please review the attached diff.
Comment 1 Svata Dedic 2015-03-03 12:22:46 UTC
Created attachment 152362 [details]
Corrected patch; added missing file.
Comment 2 Ralph Ruijs 2015-03-03 15:32:40 UTC
(In reply to Svata Dedic from comment #1)
> Created attachment 152362 [details]
> Corrected patch; added missing file.

editor.mimelookup.impl now requires org.openide.util.lookup > 8.31, but I can only find version 8.30 ?
Comment 3 Svata Dedic 2015-03-03 15:41:58 UTC
Good catch; I filed an addition issue / patch for review (see issue #250873).
Comment 4 Svata Dedic 2015-03-05 10:09:31 UTC
Created attachment 152407 [details]
Updated patch

Found some more static caches in editor.settings.storage. Caches reimplemented through Lookup-registered providers or factories.
Comment 5 Svata Dedic 2015-03-06 00:24:05 UTC
Implemented in jet-main#62421590fc40
Comment 6 Quality Engineering 2015-03-07 08:41:13 UTC
Integrated into 'main-silver', will be available in build *201503070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/62421590fc40
User: Svata Dedic <sdedic@netbeans.org>
Log: #250863: editor.settings.storage split