Jardo, Davide - can you guys please take a look at this issue ASAP?

Stepane, Vlado - can you please attach your messages.log file from the 8.0 -> 8.0.1 upgrade?

I guess it is related, some plugins (imho new in 8.0.1) have not been  installed during the update (they are offered in Available plugins after upgrade):
 - javascript2 requirejs (and these features are really missing in IDE)
 - javascript2 prototypejs
 - WildFly Application Server
 - +2 related to Java Card, imho that's ok



After that, Java Web category is missing completely in New Project wizard, Maven Web subcategories are missing in Maven category. If I check Installed plugins in Tools|Plugins, Java EE category is not displayed, but if I check "Show details", plugins from Java Web and EE are visible (as deactivated)

Created attachment 148715 [details]
log files

All log files from user dir after upgrade to 8.0.1

(In reply to Vladimir Riha from comment #3)
> Created attachment 148715 [details]
> log files
> 
> All log files from user dir after upgrade to 8.0.1

My steps were:
 - install 8.0 full distro with ergonomics (and with updates during installation)
 - create HTML5 and PHP projects
 - replace catalog link to NB distribution with the 8.0.1 staging link
 - install all updates

My steps:

 - installed full distro of 8.0
 - launched
 - nothing activated since didn't open any project
 - installed Patch 2
 - changed distribution URL to [1] and upgraded to 8.0.1
 - restarted IDE
 - Tools > Plugins > Updates offered some more plugins
 - finished upgrade and restarted IDE again

[1] http://dlc.sun.com.edgesuite.net/netbeans/updates/8.0/uc/final/distribution/catalog_stage.xml.gz

After that I don't have any "Java Wed and EE" functionality available in the IDE, it's also missing in the "Installed" tab and only "WildFly Application Server" is offered in the "Available Plugins" tab.

Product Version: NetBeans IDE 8.0.1 (Build 201408142300)
Java: 1.8.0_05; Java HotSpot(TM) 64-Bit Server VM 25.5-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_05-b13
System: Linux version 3.13.0-24-generic running on amd64; UTF-8; en_US (nb)
User directory: /home/cesilko/.netbeans/8.0
Cache directory: /home/cesilko/.cache/netbeans/8.0

Created attachment 148717 [details]
log files

Here are my log files from the upgrade process.

This is a showstopper for 8.0.1.

Hopefully this helps (and does not break other stuff) - web-main ad7e88c45865. I tested against locally built update center catalog. Please verify.

I'm not an ergonomics/module system expert so I do not actually know why it didn't work without this change so review and verification should be done carefully before applying this.

Integrated into 'main-silver', will be available in build *201408160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/ad7e88c45865
User: Petr Hejl <phejl@netbeans.org>
Log: #246476 - "EJB and EAR" plugin deactivated after 8.0 -> 8.0.1 upgrade

Testing on trunk, the patch helped with the "EJB and EAR", but other some other plugins again seems to be inactive or they are just marked as inactive. One of them is Maven for example. I can almost reproduce the case from original description just by using maven EAR project instead of an ant one. The project is closed after post-update restart and Maven projects are shown as inactive in New Project wizard, but now there's no activation when trying to open/create a project.
I'll try to test with patched release801. Will any logs would be helpful for fixing the issue?

Reopening. I'm running another build to gather more information, but so far I the problem doesn't seems to be completely fixed...

Created attachment 148747 [details]
upgrade logs

Tested with custom built 8.0.1 update center with the patch. Both "EJB and EAR" and "Maven" and a few other plugins are disabled after upgrade. Attaching all possibly helpful logs.

Transplanted to the release repo, branch release801.

http://hg.netbeans.org/releases/rev/d889be5c4b17

I looked at the latest log files by Stepan, and I don't see any helpful diagnostic message. Was there any error message? Also, when this happens, is it possible to enable "EJB and EAR" manually?

Not sure if testing on trunk is relevant, because spec numbers may affect the behavior significantly.

(In reply to Stepan Zebra from comment #12)
> Created attachment 148747 [details]
> upgrade logs
> 
> Tested with custom built 8.0.1 update center with the patch. Both "EJB and
> EAR" and "Maven" and a few other plugins are disabled after upgrade.
> Attaching all possibly helpful logs.

This test was done with JDK build 1.8.0_20-b31 and the patch was only partially effective in this environment - "JavaEE" categories are now visible in "New Project" wizard, but they are still disabled.

Using stable JDK 7 (u55) or 8 (u11), the most visible and originally reported problem seems to be fixed by the patch, but there are still related or similar problems with other plugins. They'll probably fall into different components than EAR and should be split from this issue. Note that regarding remaining issues, using JDK 7 is having slightly different results than JDK 8.

WHAT WAS FIXED BY THE PATCH:
 (on stable JDK 7 and 8)
 - Ant based EAR projects are no longer closed after post-upgrade restart
 - "Java EE" categories and "Maven Java Web/EE" subcategories no longer disappears from "New Project" wizard
 - "Java Web and EE" category no longer disappears from "Plugins" manager category view
 - "User Installed Plugins" category is no longer being deactivated in "Plugins" manager category view
 - "EJB and EAR" plugin is no longer being disabled in "Plugins" manager full view
 (on stable JDK 7)
 - "RichFaces" plugin is no longer being disabled in "Plugins" manager full view
 - "ICEfaces" plugin is no longer being disabled in "Plugins" manager full view
 (on stable JDK 8)
 - "Service Registry" category/plugin no longer disappears/is being disabled in "Plugins" manager category/full view
 - "SOAP Web Services" plugin is no longer being disabled in "Plugins" manager full view
 - "RESTful Web Services" plugin is no longer being disabled in "Plugins" manager full view

WHAT WASN'T FIXED BY THE PATCH:
 (on stable JDK 7 and 8)
 - Maven based EAR projects are being closed after post-upgrade restart
 - though no category is missing now, whole "Maven" category is disabled in "New Projects" wizard
 - "Maven" plugin is disabled in "Plugins" manager full view
 - "Java Web and EE" category is no longer disappearing, but it's now being disabled in "Plugins" manager full view, though all plugins from this category are now kept activated and "Java EE" categories are available and activated in "New Project" wizard
 - "Base IDE" category disappears from "Plugins" manager category view
 - "JavaSE" category is disabled in "Plugins" manager category view
 (on stable JDK 7)
 - "C/C++" category/plugin is being enabled in "Plugins" manager category/full view - this is most likely caused by previously unknown state that "C/C++" is being somehow activated ( = is ready for use, but shown as disabled) during IDE installation when Patch 2 is being installed
 (on stable JDK 8)
 - "HTML5" category is disabled in "Plugins" manager category view
 - "Cordova Support" plugin is disabled in "Plugins" manager full view
 - "GUI builder" plugin is disabled in "Plugins" manager full view

Setup before upgrade is freshly installed full NB 8.0 package with Patch 2, with one Ant based and one Maven based EAR project, both newly created with default options, so only needed plugins are (should be) active and receive upgrades.

Integrated into 'releases/release801', will be available in build *201408192300* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/d889be5c4b17
User: Petr Hejl <phejl@netbeans.org>
Log: #246476 - "EJB and EAR" plugin deactivated after 8.0 -> 8.0.1 upgrade
(transplanted from ad7e88c458657de738337affec16d28d99ee3be6)

Problems like this should be automatically assigned to module loader or ergonomics or update center. These modules are best suited to evaluate why no error/warning was reported yet there is a fundamental regression in the IDE.

Looking at Petr's patch it does not make any sense to me why that fix should resolve anything.

I followed the instructions and got the IDE installation into the broken state. I did few experiments:

#1) starting such broken IDE with fresh userdir and with disabled ergonomics cluster starts everything without a glitch and EE/Web functionality is available and seems to work. That indicates to me that module dependencies are most likely correct and problem is in the ergonomics module.

#2) I started IDE with another fresh userdir and with the ergonomics cluster enabled and opening Options->Plugins->Installed and ticking "Show details" I can see for example "EJB and EAR" not being activated. So I active it and everything seems to resolve again without any error being reported. There is one INFO message saying

INFO [org.netbeans.modules.autoupdate.services.FeatureUpdateElementImpl]: FeatureItem[fod.user.installed/1.0] depends on non-existing [fod.org.netbeans.modules.j2ee.kit]

which possibly could be relevant??

Stepan, when you say:

> - "HTML5" category is disabled in "Plugins" manager category view

then it looks like these may be the culprits:
javascript2.requirejs
javascript2.prototypejs

These are new modules in 8.0.1, and are kits visible in the plugin manager, which they should not be. See: http://deadlock.netbeans.org/job/nbms-and-javadoc/lastSuccessfulBuild/artifact/nbbuild/build/generated/kits.txt

If they were moved to an existing kit, e.g. ide.kit or html.angular (analogously to the change Petr H did for the WildFly plugin), would that fix the issue?

The modules javascript2.requirejs and javascript2.prototypejs are now part of the javascript2.kit . But still doesn't work. I don't know whether it helps this: http://hg.netbeans.org/web-main/rev/70b85c3da237

(In reply to Quality Engineering from comment #16)
> Integrated into 'releases/release801', will be available in build
> *201408192300* or newer. Wait for official and publicly available build.
> 
> Changeset: http://hg.netbeans.org/releases/rev/d889be5c4b17
> User: Petr Hejl <phejl@netbeans.org>
> Log: #246476 - "EJB and EAR" plugin deactivated after 8.0 -> 8.0.1 upgrade
> (transplanted from ad7e88c458657de738337affec16d28d99ee3be6)

Testing with the newly built UC, I can confirm that with stable JDK 7, problems listed in Comment 15 as FIXED are indeed fixed, excluding the problem with projects being closed. After post-upgrade restart both maven and ant EAR projects were closed. Surprisingly though, on another restart, the projects are open again...
With stable JDK 8, the problem with "EJB and EAR" being disabled still somehow happens...

Regarding HTML 5 being deactivated, I no longer see this on with JDK 7, but it still happens with JDK 8 where it might be related to Cordova plugin which is being disabled.

(In reply to Stepan Zebra from comment #20)
> ...
> With stable JDK 8, the problem with "EJB and EAR" being disabled still
> somehow happens...
> 
> ...

I run another retest with JDK 8 and after second restart the problem seems to be resolved...

If you want me to investigate something, please tell me what is wrong. The only steps that I have found are: 

 - installed full distro of 8.0
 - launched
 - nothing activated since didn't open any project
 - installed Patch 2
 - changed distribution URL to [1] and upgraded to 8.0.1
 - restarted IDE
 - Tools > Plugins > Updates offered some more plugins
 - finished upgrade and restarted IDE again

OK. I've done that. What now?

(In reply to Jaroslav Tulach from comment #22)
> If you want me to investigate something, please tell me what is wrong. The
> only steps that I have found are: 
> 
>  - installed full distro of 8.0
>  - launched
>  - nothing activated since didn't open any project
>  - installed Patch 2
>  - changed distribution URL to [1] and upgraded to 8.0.1
>  - restarted IDE
>  - Tools > Plugins > Updates offered some more plugins
>  - finished upgrade and restarted IDE again
> 
> OK. I've done that. What now?

Steps for the issue in Description were
 - install full distro of 8.0 (automaticaly upgraded to Patch 2 by installer)
 - create one JavaEE/Enterprise Application and one Maven/Enterprise Application
 - replace the current UC with 8.0.1 staging UC
 - upgrade and restart

Problem with missing functionality seems to be fixed now. Problem with disabled Java EE modules probably too, though it happened to me again during one test yesterday. The problem with EAR projects being closed after the restart is still sometimes happening. As stated in previous comments, this can be corrected by another IDE restart.

I've listed several other problems I observed in Comment 15. They are hard to grasp as they don't happen always and there was different behavior on JDK7 and JDK8.
I was told the regrouping of plugins form their categories under "User Installed Plugins" is due to the upgrades being installed into userdir, so though it's not very user friendly, statements regarding category view in Plugins manager can be considered invalid.

If no-one else is now able to reproduce the EJB and EAR or Maven plugins being disabled and EAR projects being closed, this issue can be closed as fixed.
When some of the listed problems will be encountered again a separate issue will be opened for them to investigate.

EAR projects being closed from time to time is not P1! It is not even P3. Are you sure you want to mix apples and bananas in this issue? Or would you rather close this as fixed and track the rest somewhere else?

I've done:

> Steps for the issue in Description were
>  - install full distro of 8.0 (automaticaly upgraded to Patch 2 by installer)
>  - create one JavaEE/Enterprise Application and one Maven/Enterprise
> Application
>  - replace the current UC with 8.0.1 staging UC
>  - upgrade and restart

I don't see any problem. Java EE category installed and fully enabled. Even the projects are opened correctly.

(In reply to Jaroslav Tulach from comment #24)
> EAR projects being closed from time to time is not P1! It is not even P3.
> Are you sure you want to mix apples and bananas in this issue? Or would you
> rather close this as fixed and track the rest somewhere else?

The situation was far more critical before some patches were applied. It's more stable now, some problems are not reproducible anymore, projects being closed is the most visible thing that still occur sometimes. We're still in process of verifying the situation. As the root of this particular problem may be somewhere else, it sure can be separated into another issue as well as I suggested for the other still observable problems.

(In reply to Jaroslav Tulach from comment #25)
> I've done:
> 
> > Steps for the issue in Description were
> >  - install full distro of 8.0 (automaticaly upgraded to Patch 2 by installer)
> >  - create one JavaEE/Enterprise Application and one Maven/Enterprise
> > Application
> >  - replace the current UC with 8.0.1 staging UC
> >  - upgrade and restart
> 
> I don't see any problem. Java EE category installed and fully enabled. Even
> the projects are opened correctly.

OK, let's keep this as fixed, like I already wrote:

(In reply to Stepan Zebra from comment #23)
> ...
> If no-one else is now able to reproduce the EJB and EAR or Maven plugins
> being disabled and EAR projects being closed, this issue can be closed as
> fixed.
> When some of the listed problems will be encountered again a separate issue
> will be opened for them to investigate.

Jarda, could you comment/explain please why the patch http://hg.netbeans.org/releases/rev/d889be5c4b17 resolved this issue? It does not make any sense and looks coincidental. If it is not coincidental then I would expect there to be a an error in the log (before the patch was applied) saying something "Because org.netbeans.modules.javaee.wildfly is ........something..... the EJB and EAR plugin will be deactivate." That would help to prevent this type of error in future. Thanks.

(In reply to David Konecny from comment #27)
> resolved this issue? 

What do you mean by "this issue"? As I wrote in comment #22, I can't sharply envision what is wrong. For me "this issue" is a mix of problems found when upgrading from 8.0 to 8.0.1 - and there seems to be many, mostly unrelated ones.

As far as I can say the patch
http://hg.netbeans.org/releases/rev/d889be5c4b17
enforces that once web.kit is enabled wildfly support get enabled as well. 

> I would expect there to be a an error in the log (before the patch was
> applied) saying something "Because org.netbeans.modules.javaee.wildfly is
> ........something..... the EJB and EAR plugin will be deactivate." 

There are many tests in commit validation related to behavior of kits and other modules. I would even expect there is a test that limits # of modules being visible in AU. I am surprised that such test didn't complain when javaee.wildfly was included - imho it should - WildFly seems to be me like something that is below the granularity of "kits". Another test should ensure that each module is being depended on by some (and in fact only one) kit. Why this test didn't complain before web.kit was made depending on the module is another question I would be curious to know answer to.

(In reply to Jaroslav Tulach from comment #28)
> (In reply to David Konecny from comment #27)
> > resolved this issue? 
> 
> What do you mean by "this issue"? As I wrote in comment #22, I can't sharply
> envision what is wrong. For me "this issue" is a mix of problems found when
> upgrading from 8.0 to 8.0.1 - and there seems to be many, mostly unrelated
> ones.

I followed the instructions given in this issue and was able to reproduce the problem - the EE/Web functionality disappears from the IDE after IDE upgrade. And it is puzzling why the patch should make that issue go away because the patch seem unrelated.