This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 246105 - Select next/prev element does not work anymore
Summary: Select next/prev element does not work anymore
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Editor (show other bugs)
Version: 8.0.1
Hardware: PC Windows 7
: P1 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2014-07-29 14:32 UTC by markiewb
Modified: 2014-08-11 09:28 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2014-07-29 14:32:06 UTC
Reproduction:
* invoke the action "Select next element" several times -> it works only once and "Select previous element" won't revert the selection

P2 because this is a major regression for me

Product Version: NetBeans IDE Dev (Build 201407290001)
Java: 1.8.0; Java HotSpot(TM) 64-Bit Server VM 25.0-b70
Runtime: Java(TM) SE Runtime Environment 1.8.0-b132
System: Windows 7 version 6.1 running on amd64; Cp1252; de_DE (nb)
Comment 1 Dusan Balek 2014-07-30 13:49:29 UTC
Fixed in jet-main.

http://hg.netbeans.org/jet-main/rev/2d49058c0a50
Comment 2 Quality Engineering 2014-08-01 02:10:14 UTC
Integrated into 'main-silver', will be available in build *201408010001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/2d49058c0a50
User: Dusan Balek <dbalek@netbeans.org>
Log: Issue #246105: Select next/prev element does not work anymore - fixed.
Comment 3 markiewb 2014-08-03 16:07:43 UTC
Reopen. The fix does not work. For me it is a show stopper of the RC1. That is a basic feature I use every day hundreds of times and now it does not work anymore.

Product Version: NetBeans IDE Dev (Build 201408030001)
Java: 1.8.0_05; Java HotSpot(TM) 64-Bit Server VM 25.5-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_05-b13
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)

Product Version: NetBeans IDE 8.0.1 RC1 (Build 201408011942)
Java: 1.8.0_05; Java HotSpot(TM) 64-Bit Server VM 25.5-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_05-b13
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)



(In reply to Quality Engineering from comment #2)
> Integrated into 'main-silver', will be available in build *201408010001* on
> http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
> 
> Changeset: http://hg.netbeans.org/main-silver/rev/2d49058c0a50
> User: Dusan Balek <dbalek@netbeans.org>
> Log: Issue #246105: Select next/prev element does not work anymore - fixed.
Comment 4 Jiri Kovalsky 2014-08-04 15:02:19 UTC
It does not work for me either. Works in 8.0 and does not work in 8.0.1 = regression. Dusane, can you please evaluate this issue as soon as possible?
Comment 5 Tomas Zezula 2014-08-06 19:39:23 UTC
The original fix http://hg.netbeans.org/main-silver/rev/2d49058c0a50 broken the select.
The select() method stored caret position to selOffset and set it to new one which fired a caretUpdate() and it tested if selOffset == caretPos. If not it cleared the state. Unfortunately it's always different => it does not work.
I've reverted the 2d49058c0a50 in  http://hg.netbeans.org/jet-main/rev/d71d79c6ecf4 and added several assert. Without the 2d49058c0a50 changeste I was not able reproduce any select problems. There two possibilities which may cause problems:
1st) either select or caretUpdate called out of EDT - asserted new.
2nd) The SelectCodeElementAction does not conform to Java Memory Model - fixed in http://hg.netbeans.org/jet-main/rev/38a4d06b93c1.
Can someone verify the fix? I am not able to reproduce the original problem.
If the problem persists please attach the test case.
Thanks
Comment 6 Jiri Kovalsky 2014-08-07 10:03:24 UTC
I am happy to say that the select next/previous element works fine in:

Product Version: NetBeans IDE Dev (Build jet-main-799-on-20140807)
Java: 1.8.0_11; Java HotSpot(TM) Client VM 25.11-b03
Runtime: Java(TM) SE Runtime Environment 1.8.0_11-b12
System: Linux version 3.13.0-24-generic running on i386; UTF-8; en_US (nb)

Verified in trunk of jet-main. Please integrate to release801 branch. Thanks!
Comment 7 Tomas Zezula 2014-08-07 10:18:20 UTC
Transplanted into release801: afa888b5f311, c1a5d8dd2997
Comment 8 Quality Engineering 2014-08-07 14:48:09 UTC
Integrated into 'releases/release801', will be available in build *201408071314* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/afa888b5f311
User: Tomas Zezula <tzezula@netbeans.org>
Log: #246105:Select next/prev element does not work anymore
Comment 9 Quality Engineering 2014-08-09 05:02:49 UTC
Integrated into 'main-silver', will be available in build *201408090001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/d71d79c6ecf4
User: Tomas Zezula <tzezula@netbeans.org>
Log: #246105:Select next/prev element does not work anymore
Comment 10 markiewb 2014-08-11 09:28:55 UTC
Verified the fix in 8.0.1. Thank you Tomas!

Product Version: NetBeans IDE 8.0.1 RC1 (Build 201408072300)
Java: 1.8.0; Java HotSpot(TM) 64-Bit Server VM 25.0-b70
Runtime: Java(TM) SE Runtime Environment 1.8.0-b132
System: Windows 7 version 6.1 running on amd64; Cp1252; de_DE (nb)