This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 245778 - Be prepared for svn 1.9
Summary: Be prepared for svn 1.9
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Subversion (show other bugs)
Version: 8.0
Hardware: PC Windows 7
: P1 normal with 2 votes (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-18 05:46 UTC by Ondrej Vrabec
Modified: 2016-04-03 01:44 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
draft of the upgrade patch (8.96 KB, patch)
2015-11-27 15:10 UTC, Ondrej Vrabec
Details | Diff
Updated patch (129.94 KB, patch)
2016-03-18 22:10 UTC, Ondrej Vrabec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Vrabec 2014-07-18 05:46:08 UTC
According to subversion 1.9 roadmap, they plan to release sometimes this year: http://subversion.apache.org/roadmap.html
Subversion support in NB should be prepared and offer to switch to CLI once again when it comes accross a 1.9 WC.
Comment 1 Ondrej Vrabec 2014-07-28 13:08:58 UTC
seems 1.9.0 alpha works transparently at the moment, it can work with 1.8 WCs and 1.8 SvnKit and JavaHL can both work with 1.9 checkouts. So let's check when beta is out.
Comment 2 kalwi 2015-09-03 09:02:56 UTC
Subversion 1.9 is out, the working copy format is the same as 1.8, so I currently have SVN and TortoiseSVN 1.9 installed (on Windows x64 machine) and NetBeans works with it quite good via SvnKit (JavaHL doesn't work there yet).

Sometimes I encounter some problems with locking of working copy when updating it from server by TortoiseSVN - there are conflicts of multiple threads accessing the wc.db (working copy cleanup with breaking the locks is then necessary). I'm not sure whether this is a bug in TortoiseSVN, or it's caused by a concurrent access of native client/TortoiseSVN and SvnKit from NetBeans.
Comment 3 Ondrej Vrabec 2015-09-03 13:46:22 UTC
(In reply to kalwi from comment #2)
> Subversion 1.9 is out, the working copy format is the same as 1.8, so I
> currently have SVN and TortoiseSVN 1.9 installed (on Windows x64 machine)
> and NetBeans works with it quite good via SvnKit (JavaHL doesn't work there
> yet).
That's good to hear
> 
> Sometimes I encounter some problems with locking of working copy when
> updating it from server by TortoiseSVN - there are conflicts of multiple
> threads accessing the wc.db (working copy cleanup with breaking the locks is
> then necessary). I'm not sure whether this is a bug in TortoiseSVN, or it's
> caused by a concurrent access of native client/TortoiseSVN and SvnKit from
> NetBeans.
Now that's bad to hear :-). What you're describing is probably the same as the reporter of bug 254867 posted: on Windows 10 he has the same problems. Are you on Win10?
Comment 4 kalwi 2015-09-04 09:34:01 UTC
> Now that's bad to hear :-). What you're describing is probably the same as
> the reporter of bug 254867 posted: on Windows 10 he has the same problems.
> Are you on Win10?

It's Windows 7 x64, jdk1.8.0_60 (Oracle), the latest NB nightly updates. In the opposite of the bug 254867, I had problems with TortoiseSVN, not with NetBeans.

My latest usecase which I remember was building of a (Maven) project in NB and meanwhile updating the same SVN working copy by TortoiseSVN (updated changes were only in other projects than the built one). TortoiseSVN updated the files correctly but it finally failed with locked files error (no specific file was mentioned). The working copy cleanup from TortoiseSVN was not possible (error with locked SQLite file occured) until the project build in NB was finished and I closed NB IDE application. There was no error in NB and the build finished correctly, also other SVN operations which I usually perform from NB (e.g. updating changes status by "Subversion > Show Changes", SVN history or diff) were without any errors.

Anyway, I will try to track the SVN behaviour more thoroughly and if I had a "luck" and catch some errors with more specific technical information, I will comment it again.
Comment 5 Ondrej Vrabec 2015-09-04 15:15:42 UTC
You're getting an error from TortioseSVN, sure. But unfortunately NB is not so innocent as it might seem. NetBeans too eagerly listens on external file changes and every time there is a change in the file it catches it and refreshes its svn status. So in general Tortoise might fail because:
1) it starts an update - takes some time
2) when it updates the first file NetBeans catches that and steals the access to svn db in the moment
3) now Tortoise probably fails to continue because NB is reading the metadata in the meantime

I will try to do something with this and let NetBeans yield the work with svn checkout until it gets focus: will handle it in bug #254867
Comment 6 Ondrej Vrabec 2015-11-27 15:09:00 UTC
SVN 1.9 support and JavaHL upgrade: we have to wait a while:
1) SvnClientAdapter 1.9 API is not yet ready, still work in progress
2) We need to wait for svn 1.9.3 because of this: https://github.com/apache/subversion/commit/bae2a752c110fe43a2837e10c78d82f633232319: fix for a backward incompatible change that results in JVM crashing with older JavaHL 1.8 libraries. Users with JavaHL libs in 1.8 version will not be able to use NB at all because subversion support will crach the whole JVM. SVN 1.9.3 should fix that.
Comment 7 Ondrej Vrabec 2015-11-27 15:10:06 UTC
Created attachment 157531 [details]
draft of the upgrade patch
Comment 8 jllachf 2016-02-19 08:10:27 UTC
What is the status of this issue as svn client 1.9.3 is released a few months ago ?
http://svn.apache.org/repos/asf/subversion/tags/1.9.3/CHANGES

Read nothing about 1.9 support in http://wiki.netbeans.org/FaqSubversionClients

Thanks
Comment 9 Ondrej Vrabec 2016-03-18 22:10:30 UTC
Created attachment 158922 [details]
Updated patch
Comment 10 Ondrej Vrabec 2016-04-01 12:42:14 UTC
fix: http://hg.netbeans.org/core-main/rev/4ebf3c77d171
Comment 11 Quality Engineering 2016-04-03 01:44:21 UTC
Integrated into 'main-silver', will be available in build *201604030001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/4ebf3c77d171
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #245778 - Be prepared for svn 1.9
Updating both JavaHL and SVNKit to 1.9 support.