This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 242601 - import plugins from previous release doesn't restart NetBeans when needed
Summary: import plugins from previous release doesn't restart NetBeans when needed
Status: REOPENED
Alias: None
Product: platform
Classification: Unclassified
Component: Plugin Importer (show other bugs)
Version: 8.0
Hardware: PC Windows XP
: P2 normal (vote)
Assignee: Libor Fischmeistr
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 06:05 UTC by err
Modified: 2014-04-01 11:43 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
log file (59.99 KB, text/plain)
2014-03-07 15:57 UTC, err
Details

Note You need to log in before you can comment on or make changes to this bug.
Description err 2014-03-06 06:05:07 UTC
With 8.0RC1 imported settings from 7.4. After NB startup, there was a info box that asked if I wanted to import plugins from previous release; click'd yes. Dialog came up with some plugins, selected all the plugins, click YES (or install or something like that)

NOTE: At least one of the plugins required a restart on install

Observe that the plugins are all activated and NB does NOT restart. In my case the editor became unusable (some of the plugins were for jVi).

Expected a restart. (manual restart and things are OK)
Comment 1 Marian Mirilovic 2014-03-07 07:24:48 UTC
Could you please attach messages.log files ? Thanks in advance.
Comment 2 err 2014-03-07 15:57:51 UTC
Created attachment 145841 [details]
log file
Comment 3 err 2014-03-07 15:59:40 UTC
In the attached log, note that the module
    org.netbeans.modules.jvi/0 [1.5.19.30 131127]
is turned on.

(I've changed the priority since this bug could easily cause data corruption)

In Info/info.xml from org-netbeans-modules-jvi.nbm (from its release) there is:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE module PUBLIC "-//NetBeans//DTD Autoupdate Module Info 2.5//EN" "http://www.netbeans.org/dtds/autoupdate-info-2_5.dtd">
<module codenamebase="org.netbeans.modules.jvi"
    distribution=""
    downloadsize="0"
    homepage="http://jvi.sourceforge.net/"
    license="20824F0F"
    moduleauthor="Ernie Rael"
    needsrestart="true"  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
    releasedate="2013/11/26">
Comment 4 Jiri Rechtacek 2014-03-10 09:41:54 UTC
Ernie, the import of plugins offers two different ways how to import plugins from previous installation: first, the plugin importer searches for plugins on Update Centers. If it did not find them there, then imports the plugins (i.e. copying plugins jars) directly (if all other dependencies are matched).
Back to your case, iVi plugin was found in previous installation, that's the reason why iVi was subject of import. iVi hasn't been published on any 8.0 Update Center yet, it means iVi cannot be install via NBM, so no NBM's metadata will be read. The Plugin importer had to choose the way copying the jars directly, without restart.
Hope it makes sense.
Comment 5 err 2014-03-10 13:20:13 UTC
I understand what's happening, it makes sense. But that doesn't mean it's not a bug. It is crashing part of NetBeans, the editor in this case. It could be fixed, for example by keeping more plugin metadata around. Or by always restarting if some imported NBM is not available.

I am reopening because it is a bug (IMO), so WORKSFORME is inappropriate.

Close as WONTFIX and I'll make no further comment.

PS...
The jVi Update Center, one of the plugins, is awaiting validation for 8.0. The jVi modules are loaded through this update center. I'm wondering, 
    if the jVi UC is in the 3rd party UC,
    will the plugin importer first load the jVi UC
    and then load the NBMs? (At least for jVi this
    would avoid the bug)
Comment 6 Jiri Rechtacek 2014-03-11 13:42:37 UTC
(In reply to err from comment #5)
> Close as WONTFIX and I'll make no further comment.
Or, we can tracking this as an enhancement. Perhaps some volunteer could take care of it.

> PS...
> The jVi Update Center, one of the plugins, is awaiting validation for 8.0.
> The jVi modules are loaded through this update center. I'm wondering, 
>     if the jVi UC is in the 3rd party UC,
>     will the plugin importer first load the jVi UC
Yes, it will be (except if an user is offline).

>     and then load the NBMs? (At least for jVi this
>     would avoid the bug)
Right, it should.

Regards,
Jiri