This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 242209 - I18N: org-netbeans-modules-uihandler_nb_<lang>.jar is missing
Summary: I18N: org-netbeans-modules-uihandler_nb_<lang>.jar is missing
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 8.0.2
Hardware: All All
: P2 normal (vote)
Assignee: pgebauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-22 03:51 UTC by Masaki Katakai
Modified: 2015-09-26 12:57 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2014-02-22 03:51:05 UTC
Reminder panel invoked at IDE startup are displayed in English.
It seems that these are hardcoded in ReminderPanel.java.

./uihandler/src/org/netbeans/modules/uihandler/ReminderPanel.java :

        jBottomLabel1.setText("<html>Help us improve the NetBeans IDE by providing anonymous usage data.</html>"); // NOI18N
        jBottomLabel1.setFocusable(false);
        jBottomLabel1.setRequestFocusEnabled(false);

        jBottomLabel2.setText("<html>If you agree to participate, the IDE will send anonymous information about the high-level features that you use to a database at netbeans.org.</html>"); // NOI18N
        jBottomLabel2.setFocusable(false);
        jBottomLabel2.setRequestFocusEnabled(false);

        jBottomLabel3.setText("<html>The usage statistics help us better understand user requirements and prioritize improvements in future releases. We will never reverse-engineer the collected data to find specific details about your projects.</html>"); // NOI18N
        jBottomLabel3.setFocusable(false);
        jBottomLabel3.setRequestFocusEnabled(false);

        lblLearnMore.setText("<html><font color=\"#0000FF\" <u>Learn more</u></font></html>"); // NOI18N

Please extract these messages to resource bundle.
Comment 1 Masaki Katakai 2014-02-22 04:22:27 UTC
It seems that resource bundle are provided in

./netbeans_platform/platform/uihandler/uihandler/org/netbeans/modules/uihandler/Bundle.properties
./netbeans_ide/nb/ide-branding/locale/uihandler_nb/org/netbeans/modules/uihandler/Bundle_nb.properties

But it's not localized. I will check the detail. It seems that localization issue.
Comment 2 Masaki Katakai 2015-01-16 10:21:40 UTC
Here is a module, which is displaying the reminder messages.

nb/modules/locale/org-netbeans-modules-uihandler_nb.jar

However, corresponding localized jar files are provided as below.

nb/modules/locale/uihandler_nb_pt_BR.jar
nb/modules/locale/uihandler_nb_ru.jar
nb/modules/locale/uihandler_nb_zh_CN.jar
nb/modules/locale/uihandler_nb_ja.jar

I understand the followings are correct jar file,
"org-netbeans-modules-" is missing.

nb/modules/locale/org-netbeans-modules-uihandler_nb_pt_BR.jar
nb/modules/locale/org-netbeans-modules-uihandler_nb_ru.jar
nb/modules/locale/org-netbeans-modules-uihandler_nb_zh_CN.jar
nb/modules/locale/org-netbeans-modules-uihandler_nb_ja.jar

When I renamed nb/modules/locale/uihandler_nb_ja.jar to nb/modules/locale/org-netbeans-modules-uihandler_nb_ja.jar,
the reminder message is displayed properly in Japanese.

So please evaluate build process and evaluate why
uihandler_nb_ja.jar is generated instead of org-netbeans-modules-uihandler_nb_ja.jar.
Comment 3 pgebauer 2015-09-21 13:46:56 UTC
Where can I find the following files?

nb/modules/locale/uihandler_nb_pt_BR.jar
nb/modules/locale/uihandler_nb_ru.jar
nb/modules/locale/uihandler_nb_zh_CN.jar
nb/modules/locale/uihandler_nb_ja.jar

I cannot see them in http://bits.netbeans.org/trunk/nightly/latest/zip/ide-l10n-201509210002.zip . 

I can only see following files 

netbeans/modules/locale/org-netbeans-modules-uihandler_ja.jar.pack.gz
netbeans/modules/locale/org-netbeans-modules-uihandler_pt_BR.jar.pack.gz
netbeans/modules/locale/org-netbeans-modules-uihandler_ru.jar.pack.gz
netbeans/modules/locale/org-netbeans-modules-uihandler_zh_CN.jar.pack.gz

in http://bits.netbeans.org/trunk/nightly/latest/uc/platform/org-netbeans-modules-uihandler.nbm. However all files contain string "org-netbeans-modules-" in their names.
Comment 4 Masaki Katakai 2015-09-23 06:09:35 UTC
I understand these are branding files, it's included in

  http://bits.netbeans.org/trunk/nightly/latest/uc/nb/org-netbeans-modules-ide-branding.nbm

$ jar tvf org-netbeans-modules-ide-branding.nbm | grep uihand
  2773 Tue Sep 22 00:40:48 PDT 2015 netbeans/modules/locale/org-netbeans-modules-uihandler_nb.jar.pack.gz
  2829 Tue Sep 22 00:40:48 PDT 2015 netbeans/modules/locale/uihandler_nb_ja.jar.pack.gz
  2586 Tue Sep 22 00:40:48 PDT 2015 netbeans/modules/locale/uihandler_nb_pt_BR.jar.pack.gz
  2968 Tue Sep 22 00:40:48 PDT 2015 netbeans/modules/locale/uihandler_nb_ru.jar.pack.gz
  2792 Tue Sep 22 00:40:48 PDT 2015 netbeans/modules/locale/uihandler_nb_zh_CN.jar.pack.gz
$

"org-netbeans-modules-uihandler_nb.jar.pack.gz" is English jar file.
Corresponding l10n jar files should be

   org-netbeans-modules-uihandler_nb_<lang>.jar.pack.gz

However, as you can see above, "org-netbeans-modules-" is missing

   uihandler_nb_ja.jar.pack.gz

I'm not sure why l10n jar files is created like this.

Correspondig Bundle.properties is

   nb/ide-branding/locale/uihandler_nb/org/netbeans/modules/exceptions/Bundle_nb.properties

and localized in http://smetiste.cz.oracle.com/builds/netbeans/trunk/daily/2015-09-23_00-02-28/zip/ide-l10n-201509230002.zip
Comment 5 pgebauer 2015-09-23 09:49:49 UTC
The problem is caused by the wrong name of uihandler directories at following places:

http://hg.netbeans.org/releases/l10n/file/1f40d4ba6932/src/ja/nb/ide-branding/locale
http://hg.netbeans.org/releases/l10n/file/1f40d4ba6932/src/pt_BR/nb/ide-branding/locale
http://hg.netbeans.org/releases/l10n/file/1f40d4ba6932/src/ru/nb/ide-branding/locale
http://hg.netbeans.org/releases/l10n/file/1f40d4ba6932/src/zh_CN/nb/ide-branding/locale

The name uihandler_nb is used but the name org-netbeans-modules-uihandler_nb should be used.

I'm not sure if I can rename it myself or somebody from l10n team will fix it. I don't know all dependencies towards l10n processes.
Comment 6 Masaki Katakai 2015-09-24 08:03:16 UTC
Hi Petr,

"org-netbeans-modules" is always omitted at creating l10n-kit for all files so that we avoid very long name in l10n source tree.

I think build process is reverting this short name to correct jar file by adding "org-netbeans-modules".

I don't know the detail in build process but I noticed the following codes:

nbbuild/antsrc/org/netbeans/nbbuild/LocFiles.java:

    private String fixJarName(String prefixDir, String name) {

        ....

        if (name.equals("autoupdate-ui_nb")) {
            return "org-netbeans-modules-autoupdate-ui_nb";
        }
        if (name.equals("options-api_nb")) {
            return "org-netbeans-modules-options-api_nb";
        }
    }

It seems that there are some irregular files around "nb". Do you think we can fix this issue by adding these codes?

        if (name.equals("uihandler_nb")) {
            return "org-netbeans-modules-uihandler_nb";
        }

Could you try? or please tell me the simplest steps for l10n build. I'll try.
Comment 7 pgebauer 2015-09-24 23:16:38 UTC
I have tried your fix and jar files have been generated correctly without renaming of uihandler directories in the l10n repo.

http://hg.netbeans.org/core-main/rev/90106345f761
Comment 8 Quality Engineering 2015-09-26 12:57:46 UTC
Integrated into 'main-silver', will be available in build *201509261150* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/90106345f761
User: PGebauer <pgebauer@netbeans.org>
Log: #242209 - I18N: org-netbeans-modules-uihandler_nb_<lang>.jar is missing