This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 241751 - Angular support sometime doesn't work
Summary: Angular support sometime doesn't work
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: AngularJS (show other bugs)
Version: 7.4
Hardware: PC Linux
: P1 normal (vote)
Assignee: Petr Pisl
URL:
Keywords: 8.0_HR_FIX
Depends on: 241339
Blocks:
  Show dependency tree
 
Reported: 2014-02-12 10:15 UTC by Petr Pisl
Modified: 2014-03-07 02:39 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
The fix in angular and js editor (1.86 KB, application/octet-stream)
2014-03-04 14:36 UTC, Petr Pisl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Pisl 2014-02-12 10:15:45 UTC
The Angular support is based on the indexing sources. It has its indexer, which uses data from JavaScript indexer. (JavaScript indexer collects some data for frameworks.) So during indexing the JavaScript indexer has to run before the Angular indexer. Sometimes the Angular indexer is started before JavaScript indexer and then the support doesn't work.

In such case you have to restart ide, because the order of indexer is not defined properly and is random.
Comment 1 Petr Pisl 2014-02-17 09:56:30 UTC
Adding position of the indexers in layer.xml files was pushed to the web-main
Comment 2 Quality Engineering 2014-02-18 03:15:23 UTC
Integrated into 'main-silver', will be available in build *201402180001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/1115ef6bb8ae
User: Petr Pisl <ppisl@netbeans.org>
Log: #241751 - Angular support sometime doesn't work
Adding position of the indexers, this is not a fix
Comment 3 Petr Pisl 2014-02-18 07:26:47 UTC
I had to revert the changeset: http://hg.netbeans.org/main-silver/rev/1115ef6bb8ae, because it caused failing commit validation. The reason is that in such case we have to add ordering to all files in the folder.
Comment 4 Petr Jiricka 2014-02-19 07:47:32 UTC
Stopper for 8.0 -> P1.
Comment 5 Marian Mirilovic 2014-03-04 06:54:30 UTC
(In reply to Petr Jiricka from comment #4)
> Stopper for 8.0 -> P1.

So, what is the status ? ... no update for last 2 weeks ;(
Comment 6 Petr Pisl 2014-03-04 14:16:10 UTC
So the issue #241339 is fixed. I have tested the fix and it seems to work together with my fix at angular. I need to wait until the Tomas's fix is propagated to the web-main.
Comment 7 Marian Mirilovic 2014-03-04 14:24:13 UTC
Ok, but we need to have this in rlease80 branch as soon as possible!
I asked Tomas for integration of bugfix of issue #241339 today.
Comment 8 Petr Pisl 2014-03-04 14:36:36 UTC
Created attachment 145747 [details]
The fix in angular and js editor

OK, if it's enough that was tested by me, I can put my fix there as well. It's just implementation of the Tomas's ordering methods. It's very simple patch.
Comment 9 Marian Mirilovic 2014-03-04 14:47:48 UTC
Ook, please do so ... thanks in advance.
Comment 10 Petr Pisl 2014-03-04 19:11:21 UTC
Fixed in web-main: http://hg.netbeans.org/web-main/rev/db81fab8280c also transplanted Tomas's change to the web-main: http://hg.netbeans.org/web-main/rev/3f65bfade5db
Comment 11 Petr Pisl 2014-03-04 19:18:54 UTC
Transplanted to the releases / release80. http://hg.netbeans.org/releases/rev/d0ccedc68ed2
Comment 12 Quality Engineering 2014-03-06 01:11:42 UTC
Integrated into 'releases/release80', will be available in build *201403052200* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/d0ccedc68ed2
User: Petr Pisl <ppisl@netbeans.org>
Log: #241751 - Angular support sometime doesn't work
Comment 13 Vladimir Riha 2014-03-06 16:07:25 UTC
I've tested completion for AngularJS and it didn't cause any regression thus marking as verified.

Product Version: NetBeans IDE 8.0 (Build 201403052200)
Java: 1.8.0; Java HotSpot(TM) Client VM 25.0-b69
Runtime: Java(TM) SE Runtime Environment 1.8.0-b131
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 14 Quality Engineering 2014-03-07 02:39:55 UTC
Integrated into 'main-silver', will be available in build *201403070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/db81fab8280c
User: Petr Pisl <ppisl@netbeans.org>
Log: #241751 - Angular support sometime doesn't work