This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 241042 - Extend CodeCompletionHandler2.documentElement method for the cancel parameter
Summary: Extend CodeCompletionHandler2.documentElement method for the cancel parameter
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: CSL (API & infrastructure) (show other bugs)
Version: 8.0
Hardware: All All
: P3 normal (vote)
Assignee: Martin Fousek
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 240749
  Show dependency tree
 
Reported: 2014-01-28 07:37 UTC by Martin Fousek
Modified: 2014-02-03 08:24 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
csl patch v1 (10.12 KB, patch)
2014-01-28 07:37 UTC, Martin Fousek 		Details | Diff
clients patch v1 (18.13 KB, patch)
2014-01-28 07:38 UTC, Martin Fousek 		Details | Diff
csl patch v2 (10.12 KB, patch)
2014-01-28 07:45 UTC, Martin Fousek 		Details | Diff
clients patch v2 (18.43 KB, patch)
2014-01-28 07:47 UTC, Martin Fousek 		Details | Diff
csl patch v3 (10.33 KB, patch)
2014-01-28 15:50 UTC, Martin Fousek 		Details | Diff
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fousek 2014-01-28 07:37:06 UTC 
Created attachment 144445 [details]
csl patch v1

Into nb80 goes new interface CodeCompletionHandler2 with method documentElement(). I would like to extend this new method for parameter cancel which could signal to the client that the originated request was already cancelled and that it can stop the computation.

This should resolve performance issues where is code completion blocked by the request for obtaining documentation.

I'm attaching patch with changes to the csl module and patch with changes in clients (php.editor, php.latte, php.twig, javascript2.editor) including usage of the extended API in the web.el module.
Comment 1 Martin Fousek 2014-01-28 07:38:58 UTC 
Created attachment 144446 [details]
clients patch v1
Comment 2 Martin Fousek 2014-01-28 07:45:06 UTC 
Created attachment 144447 [details]
csl patch v2

Added @NonNull annotation to the parameter.
Comment 3 Martin Fousek 2014-01-28 07:47:39 UTC 
Created attachment 144449 [details]
clients patch v2
Comment 4 Ondrej Brejla 2014-01-28 09:07:43 UTC 
OB01: Please, just add some better explanation how should be that Callable used, implemented. Imho for implementators, this pattern will not be clear enough ;) Thanks.
Comment 5 Martin Fousek 2014-01-28 15:50:32 UTC 
Created attachment 144478 [details]
csl patch v3

(In reply to Ondrej Brejla from comment #4)
> OB01: Please, just add some better explanation how should be that Callable
> used, implemented. Imho for implementators, this pattern will not be clear
> enough ;) Thanks.

JavaDoc updated to be clearer to clients. Thanks.
Comment 6 Martin Fousek 2014-01-31 07:38:27 UTC 
If there are no other objections, I'm going to integrate the patch on Monday.

Thank you for reviewing.
Comment 7 Martin Fousek 2014-02-03 08:24:26 UTC 
Thanks for the review.

Integrated in web-main #1cf3259c35e5.