This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 240877 - Goto file now show files from /target folder
Summary: Goto file now show files from /target folder
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Jump To (show other bugs)
Version: 8.0
Hardware: PC Windows 8 x64
: P2 normal with 1 vote (vote)
Assignee: Tomas Zezula
URL:
Keywords: 8.0_HR_FIX, REGRESSION
: 191119 240828 242646 242726 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-23 11:46 UTC by akobberup
Modified: 2014-03-17 11:31 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
In this search i usually only get the .java file and 3 .properties files. Now i get 12 files as the compiled/copied files from /target is also returned. (50.22 KB, image/png)
2014-01-23 11:46 UTC, akobberup
Details

Note You need to log in before you can comment on or make changes to this bug.
Description akobberup 2014-01-23 11:46:33 UTC
Created attachment 144290 [details]
In this search i usually only get the .java file and 3 .properties files. Now i get 12 files as the compiled/copied files from /target is also returned.

In new snapshots of nb, it seems that goto file besides returning the files it use to (those from src/..) it also refurn files from target folder.

I get it that the files match the search pattern, but it is hardly useable.

If this change is intentional, it would be extremely nice if it were an option to let "goto file" use the same ignore patterns that can be applied in the "find in project" dialog.


Product Version: NetBeans IDE Dev (Build 201401200001)
Java: 1.7.0_45; Java HotSpot(TM) 64-Bit Server VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Windows 8 version 6.2 running on amd64; Cp1252; da_DK (nb
Comment 1 NukemBy 2014-02-22 15:47:37 UTC
Having the same problem in MAVEN projects, NB Dev 201402190001. NB 7.4 does not show files from 'target' (what is the behavior expected by me). I expect only files from defined MAVEN 'source' folders should be in 'go to file'. See bug https://netbeans.org/bugzilla/show_bug.cgi?id=239769.
Comment 2 Tomas Zezula 2014-02-24 18:29:31 UTC
Unfortunately the change is intentional. The shareability filter needed to be removed due to performance reason. The Maven project ShareabilityQuery can block  the Go To File for 70+ seconds which is not acceptable.
Comment 3 NukemBy 2014-02-25 16:57:09 UTC
I'm not sure what this means ('shareability filter' and 'Maven project ShareabilityQuery'), but would it be possible to review NetBeans internal architecture so that sources scanner use actuall configuration of the MAVEN POMs to identify read sources but not just 'all files from root'?

This way number of (actually not needed) files should be significantly reduced what will significantly ...
- improve performance of NetBeans - less files to be scanned and analysized
- improve user experience - I will not have to manually sort out autogenerated and non-source files from "Go To File" and "Search Result" windows
Comment 4 NukemBy 2014-02-25 16:58:36 UTC
PS: this is what i already noted in https://netbeans.org/bugzilla/show_bug.cgi?id=239768
Comment 5 Tomas Zezula 2014-02-25 17:13:47 UTC
>but would it be possible to review NetBeans internal architecture so that sources >scanner use actuall configuration of the MAVEN POMs to identify read sources but >not just 'all files from root'?
This is what the MavenVisibilityQuery and MavenShareabilityQuery does.
They hide the folders which are not visible or excluded from versioning (build folders). Unfortunately when the Maven project caches are invalid it takes very long time to build them from the pom file. For example in the following snapshot https://netbeans.org/bugzilla/attachment.cgi?id=139998 more than 80s is spent in MavenShareabilityQuery building project model from POM file. 80s is much more then crawling the build folder.
I can return the shareability filter but it makes the Go To File unusable for some users.
Comment 6 NukemBy 2014-02-25 17:17:35 UTC
Thanks, status is clear now. I suppose there should be a 3rd way of architecture which makes both groups of users happy. Hopefully soon.
Comment 7 Tomas Zezula 2014-03-05 13:09:24 UTC
*** Bug 240828 has been marked as a duplicate of this bug. ***
Comment 8 Tomas Zezula 2014-03-05 13:12:44 UTC
I've decided to return the filters back (8.0). 
The slow maven project should be solved on maven loader side.
If not solved by mvn we can at least allow partial results showing the files under sources before blocking in pom loading, but this is non trivial (next).
Comment 9 Tomas Zezula 2014-03-05 13:15:43 UTC
Fixed jet-main e074b4da81bf
Comment 10 Tomas Zezula 2014-03-05 13:46:30 UTC
Transplanted into NB 8.0 2fabb10eb5f9
Comment 11 Quality Engineering 2014-03-06 01:11:53 UTC
Integrated into 'releases/release80', will be available in build *201403052200* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/2fabb10eb5f9
User: Tomas Zezula <tzezula@netbeans.org>
Log: #240877:Goto file now show files from /target folder
Comment 12 akobberup 2014-03-06 07:28:35 UTC
Tomas - this is great news. Is the bug on the Maven project ShareabilityQuery reported somewhere?

-Kind regards
Anders
Comment 13 NukemBy 2014-03-06 08:40:36 UTC
In (Build 201403060001) I still see files from 'target' in GoTo dialog.
Comment 14 Tomas Zezula 2014-03-06 08:45:16 UTC
You need to wait until the change is integrated to daily builds (main-silver).
For now it's in jet-main builds and NB 8 (next release candidate).
Comment 15 Jiri Prox 2014-03-07 09:50:48 UTC
*** Bug 242646 has been marked as a duplicate of this bug. ***
Comment 16 Quality Engineering 2014-03-12 02:48:03 UTC
Integrated into 'main-silver', will be available in build *201403120001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/e074b4da81bf
User: Tomas Zezula <tzezula@netbeans.org>
Log: #240877:Goto file now show files from /target folder
Comment 17 Jiri Prox 2014-03-12 14:30:17 UTC
*** Bug 242726 has been marked as a duplicate of this bug. ***
Comment 18 Jiri Prox 2014-03-12 14:31:53 UTC
verified in 8.0
Comment 19 Jiri Prox 2014-03-17 11:31:28 UTC
*** Bug 191119 has been marked as a duplicate of this bug. ***