This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 236030 - Configure JSTestDriver contains incomplete browser identification
Summary: Configure JSTestDriver contains incomplete browser identification
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Project (show other bugs)
Version: 7.4
Hardware: All All
: P1 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords: 7.4_HR_FIX
Depends on:
Blocks:
 
Reported: 2013-09-16 13:38 UTC by Vladimir Riha
Modified: 2013-09-26 11:29 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
screenshot (28.53 KB, image/png)
2013-09-16 13:38 UTC, Vladimir Riha 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2013-09-16 13:38:59 UTC 
Created attachment 140130 [details]
screenshot

Might be caused by fixing issue 235711, if I invoke Test action on HTML5 project, there is no way to differentiate Chrome vs Chrome with NB integration (connector)

I don't think this is a stopper for RC1 as it is not that exposed feature and "workaround" is to use trial-error method (which in case of 2 options is at least quick). But definitely should be fixed in 7.4



Product Version: NetBeans IDE 7.4 RC1 (Build 201309152201)
Java: 1.8.0-ea; Java HotSpot(TM) Client VM 25.0-b49
Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b107
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 1 David Konecny 2013-09-17 06:08:39 UTC 
Fixed in ad245cf0779e

This is a regression caused by fix of issue 235711.

The fix is fixing the same problem when top level menu "Run -> Set Project Browser" is used.

This is a very simple fix and I recommend it for inclusion in 7.4 if time permits. Many users can be potentially confused by this UI glitch.

Tomas, could you please review and if it is OK and QA agrees could you push this please through HR process and into 74 release branch? Thanks.
Comment 2 Tomas Mysik 2013-09-17 06:43:03 UTC 
The fix is OK. Any other places where the new browser name could cause this problem, please? Just let me know, I will fix it.

Thanks.
Comment 3 David Konecny 2013-09-17 20:34:53 UTC 
I did not find any other places.

Lado, could you verify the fix? I will post HR review request now.
Comment 4 Quality Engineering 2013-09-18 02:09:18 UTC 
Integrated into 'main-silver', will be available in build *201309180002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/ad245cf0779e
User: David Konecny <dkonecny@netbeans.org>
Log: #236030 - Configure JSTestDriver contains incomplete browser identification
Comment 5 Vladimir Riha 2013-09-19 07:54:24 UTC 
Verified in trunk, thank you.

Product Version: NetBeans IDE Dev (Build 201309190428)
Java: 1.8.0-ea; Java HotSpot(TM) Client VM 25.0-b49
Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b107
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 6 Tomas Mysik 2013-09-19 08:06:25 UTC 
Davide, have you sent an e-mail to reviewers or not? If not, I will do that and then transplant the fix to 74 branch.

Thanks.
Comment 7 David Konecny 2013-09-19 20:25:01 UTC 
Thanks Tomas. I had releases repo up to date so I transplated the fix: 9384a340bdd8
Comment 8 Tomas Mysik 2013-09-20 04:51:18 UTC 
OK, thanks!
Comment 9 Vladimir Riha 2013-09-26 11:29:23 UTC 
Verified

Product Version: NetBeans IDE 7.4 RC2 (Build 201309252201)
Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b13
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)