This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 23584 - search filesystem should not search binary / class files
Summary: search filesystem should not search binary / class files
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: Marian Petras
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2002-05-16 08:14 UTC by tveimo
Modified: 2005-02-17 15:07 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tveimo 2002-05-16 08:14:20 UTC 
The search filesystem dialog matches class files
as well as source files. It would be nice to be
able to specify searching only java files,
notclass files or not binary files.
Comment 1 Marek Grummich 2002-07-22 11:53:36 UTC 
Set target milestone to TBD
Comment 2 Marek Grummich 2002-07-22 11:56:15 UTC 
Set target milestone to TBD
Comment 3 Marian Petras 2003-02-24 10:39:13 UTC 
It is possible to specify that only Java files are to be searched. But
it is not user-friendly. By default (if the user does not specify
otherwise), all text files should be searched.
Comment 4 Jesse Glick 2004-02-05 21:38:33 UTC 
In promo-D you will be able to use SharabilityQuery to differentiate
sources from build products, which is a good start. Won't stop you
from e.g. searching in versioned image files.
Comment 5 Marian Petras 2004-10-18 15:37:03 UTC 
The search feature already uses SharabilityQuery - see bug #44310
("Search should ignore nonsharable files").

The remaining issue is that fulltext search should skip binary files,
but if fulltext is not used (e.g. searching by object type or name)
all files should be examined.
Comment 6 Marian Petras 2005-02-17 15:04:13 UTC 
Done in NetBeans 4.0.

Modified file:

    utilities/src/org/netbeans/modules/search/types/FullTextType.java
                                                          (1.42)

Diff:
http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/search/types/FullTextType.java.diff?r1=1.41&r2=1.42&f=u
Comment 7 Marian Petras 2005-02-17 15:07:44 UTC 
A deficiency has been later found in the implementation (see bug
#52256 - "Find does not work on XSL nor XSD files in 4.0 RC2") and
fixed in revision 1.46 of the same file.