This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 233369 - Use "--sourcemap" for Sass 3.3+
Summary: Use "--sourcemap" for Sass 3.3+
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: CSS Preprocessors (SASS, LESS, ...) (show other bugs)
Version: 7.4
Hardware: All Windows 7 x64
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on: 233384
Blocks:
  Show dependency tree
 
Reported: 2013-07-25 07:39 UTC by Petr Jiricka
Modified: 2014-06-10 09:11 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2013-07-25 07:39:38 UTC 
From e-mail by Tomas Mysik from Jul 24th: 
"we could use "--debug-info" for Sass 3.2.x only and "--sourcemap" for Sass 3.3+. But I am not sure whether it would break anything..."

As David points out, the SASS support in the visual CSS editor will need to be updated at the same time.
Comment 1 Tomas Mysik 2013-07-25 07:43:30 UTC 
Just to be sure - this is easy to do for me but Marek will need to improve the editor part, right? Or am I wrong?

Thanks.
Comment 2 Jan Stola 2013-07-25 08:10:29 UTC 
The improvement of CSS Styles view (to be source map aware) is my area. Marek's future SASS-related improvements of Rule Editor are not dependent on the compilation options of SASS files AFAIK.
Comment 3 Tomas Mysik 2013-07-25 08:21:51 UTC 
I see, thanks for explanation Honzo.
Comment 4 Tomas Mysik 2013-07-25 08:23:46 UTC 
Maybe Honzo assign this issue to yourself and once it is done, reassign to me (we will not break anything in this case; if I do it first, we will break visual CSS). Do you agree?

Thanks.
Comment 5 Jan Stola 2013-07-25 08:52:50 UTC 
I have extracted my part into a separate issue 233384 that blocks this issue.
Comment 6 Tomas Mysik 2013-07-25 08:54:52 UTC 
OK, thanks a lot!
Comment 7 Tomas Mysik 2013-08-29 11:40:07 UTC 
Guys, since Honza fixed his part, should not this issue be changed to DEFECT and fixed for NB 7.4? I would think so...

Thanks.
Comment 8 Petr Jiricka 2013-08-29 12:18:37 UTC 
Good idea, thanks Tomas, yes please do it. For some reason I was thinking that this is already done, I guess I confused this with issue 232583.
Comment 9 Tomas Mysik 2013-08-29 12:20:29 UTC 
Will do it, tomorrow, thanks.
Comment 10 David Konecny 2013-08-29 21:09:51 UTC 
(In reply to Petr Jiricka from comment #8)
> For some reason I was thinking that this is already done

Me too. So what are you going to do Tomas which has not been implemented in issue 232583 yet?
Comment 11 Tomas Mysik 2013-08-30 05:17:01 UTC 
(In reply to David Konecny from comment #10)
> Me too. So what are you going to do Tomas which has not been implemented in
> issue 232583 yet?

If debug is enabled (in IDE Otions), use --sourcemap for Sass 3.3+ OR --debug-info for Sass 3.2 (now, --debug-info is always used).

Thanks.
Comment 12 Tomas Mysik 2013-08-30 07:05:50 UTC 
Done. Davide/Honzo, please review my change to ensure that it is correct.

http://hg.netbeans.org/web-main/rev/3eb95eedbc09

Thanks.
Comment 13 Tomas Mysik 2013-09-02 05:02:41 UTC 
Láďo, please verify that Easel support works correctly for both Sass versions (3.2 even 3.3).

Thanks a lot.
Comment 14 Vladimir Riha 2013-09-02 06:19:53 UTC 
Generating either source map or debug info works fine and when old debug info is used, CSS Styles recognize source sass file. But that doesn't work for me in case of source maps, I'll reopen and comment issue 233384


Product Version: NetBeans IDE Dev (Build web-main-11515-on-20130901) & Latest trunk

Java: 1.7.0_40; Java HotSpot(TM) Client VM 24.0-b55
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b39
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 15 slWsu 2014-06-10 09:02:15 UTC 
Hello, I'm french so sorry for my English. 
I do not know whether I have the right to post here, I just got up on NetBeans, in case of error, thank you let me know. 

I use a Framework sass personel, I wish I could in this $ fmk use the map: (key1: # fff, key2: full); the concern is that NB returns me an error, I feel this bug is fixed but I am unable to set up, can you give me the march follow ... 
Thank you in advance.
Comment 16 Vladimir Riha 2014-06-10 09:11:28 UTC 
This is a different thing, this issue is about source maps and you have Map data structure, it is tracked in issue 244667.