This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
1. Install NetBeans and activate PHP plugin. 2. Goto Tools>>Options>>PHP>>Code Anlysis tab and add path to Code Sniffer and Mess Detector. 3. Notice Apply Button is enabled, so press it. 4. Apply Button stays enabled and stays enabled on any menu item or tab in Options, even after clicking it. Expected: Apply Button is disabled after clicking it. Workaround: Close Options and reopen them. Product Version: NetBeans IDE Dev (Build 201307032300) Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b01 Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b16 System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
Using debugger, I just verified that after clicking the Apply button, no PROP_CHANGED is fired from AnalysisOptionsPanelController (see php.code.analysis module) so the problem is not in the PHP area. Reporter confirms that (point 4.). Please evaluate, thanks.
One note: (In reply to comment #1) > Using debugger, I just verified that after clicking the Apply button, no > PROP_CHANGED is fired from AnalysisOptionsPanelController This was fixed yesterday so please be sure that this fix has already been propagated to your repo. Thanks.
Now this is what is happening: 1. Install NetBeans and activate PHP plugin. 2. Goto Tools>>Options>>PHP>>Code Analysis tab and add path to Code Sniffer and Mess Detector. Also choose a Default Standard from the drop down list. 3. Notice the Apply button is NOT enabled, although it should be! Click OK. 4. Reopen Tools>>Options and PHP>>Code Analysis tab is already open, but the Tool paths and Default Standard was NOT saved and the fields are blank. Notice now the Apply button is enabled. 5. Once again, add path to Code Sniffer and Mess Detector and choose a Default Standard. Click the Apply button. The Apply button stays enabled. 6. Click OK to Exit. 7. Open Options again and the values are still there this time, but the Apply button is still activated. The Apply Button is activated when Options is open if the last item open was any PHP tab. If I choose any other menu Item, like Java or Misc, before I exit Options, the Apply button is disabled when opening Options again and will not auto activate when viewing PHP tabs. Workaround 1: It takes 2 times to add tools to PHP Code Analysis Tab the first time. Workaround 2: Choose another menu item besides PHP before exiting Options so Apply button is not activated when Options is opened. Product Version: NetBeans IDE Dev (Build 201307232300) Updates: Updates available Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b01 Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b16 System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
The problem is in BaseOptionsPanelController and AnalysisOptionsPanelController. After the update method is called the 'changed' variable is set to true. This is checked by options and thus the Apply button gets activated again. re-assigning. Thank you
Should be fixed now. Thanks. http://hg.netbeans.org/web-main/rev/be8b26eb5f7d
Integrated into 'main-silver', will be available in build *201308150051* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/be8b26eb5f7d User: Tomas Mysik <tmysik@netbeans.org> Log: #232279 - Apply button stays enabled when adding code analysis to PHP
Works fine now. Verified. Thanks for reporting. Product Version: NetBeans IDE Dev (Build 201308182300) Java: 1.7.0_40; Java HotSpot(TM) 64-Bit Server VM 24.0-b55 Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b39 System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb)