This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 231865 - Rename shows warning only after Rename getters and setters is selected
Summary: Rename shows warning only after Rename getters and setters is selected
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Ralph Ruijs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-26 19:29 UTC by misterm
Modified: 2015-04-03 03:08 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description misterm 2013-06-26 19:29:45 UTC
In a class with a private member variable, with the cursor over the variable, hit CTRL + R. No warning is shown and all buttons are enabled. After selecting Rename Getters and Setters, a warning message is shown and buttons are disabled.

Product Version = NetBeans IDE Dev (Build 20130626-ac93781533c7)
Operating System = Windows 7 version 6.1 running on amd64
Java; VM; Vendor = 1.7.0_07
Runtime = Java HotSpot(TM) 64-Bit Server VM 23.3-b01
Comment 1 Ralph Ruijs 2013-06-26 21:41:27 UTC
In a class with a private member variable with getter/setter methods, invoke rename on the variable. The old name in the textfield is selected and has focus, allowing the user to change the name right away. Clicking on the checkbox to Rename Getters and Setters, the user gets a warning that the name is not changed.

I think this is how it should work, giving the error immediately has no added value, as the user was not able to change the name yet.


How should this be changed?
Comment 2 misterm 2013-06-27 13:07:50 UTC
It should either display the message immediately or once the user moves to the nxt step. Displaying it once the checkbox is marked gives the impression it really has to do with some requirement added by that option, which is not true. I've submitted this issue because the current behaviour got me puzzled for some good seconds and I think it's unnecessary this dialog behaves this way.
Comment 3 Ralph Ruijs 2015-03-31 10:37:38 UTC
changeset:   75a0a19aa638
user:        Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
date:        Tue Mar 31 12:34:39 2015 +0200
summary:     #231865 - Rename shows warning only after Rename getters and setters is selected
Comment 4 Quality Engineering 2015-04-03 03:08:12 UTC
Integrated into 'main-silver', will be available in build *201504030001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/75a0a19aa638
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: #231865 - Rename shows warning only after Rename getters and setters is selected