This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 231067 - Remove the need for implementation dependencies in livehtml.cli module
Summary: Remove the need for implementation dependencies in livehtml.cli module
Status: RESOLVED FIXED
Alias: None
Product: contrib
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.4
Hardware: PC Linux
: P3 normal (vote)
Assignee: issues@contrib
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2013-06-11 08:47 UTC by Jaroslav Tulach
Modified: 2014-07-22 02:32 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Adding as friend to web.webkit.debugging and web.browser.api (2.44 KB, patch)
2013-06-11 09:33 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2013-06-11 08:47:41 UTC
The livehtml module 
http://hg.netbeans.org/main/contrib/rev/45c9c27c96a0
uses implementation dependencies to various APIs which will complicate its distribution over autoupdate.

This issue is created to track remove of these dependencies.
Comment 2 Jaroslav Tulach 2013-06-11 09:33:52 UTC
Created attachment 135626 [details]
Adding as friend to web.webkit.debugging and web.browser.api
Comment 3 Jaroslav Tulach 2013-06-11 09:35:07 UTC
OK?
Comment 4 Stanislav Aubrecht 2013-06-11 11:25:35 UTC
(In reply to comment #3)
> OK?

ok
Comment 5 Petr Jiricka 2013-06-11 11:33:50 UTC
Looks fine, let me just note that the name of the module is rather confusing - there already is a web.livehtml module in the main repository.
Comment 6 Jaroslav Tulach 2013-06-11 12:35:31 UTC
Maybe the two modules could be merged one day!? 

The module provides support for 
--livehtml 
command line parameter, thus I used livehtml in its name. 

I've also noticed there is web.livehtml module and when I saw that I considered rename of the contrib module to org.netbeans.modules.web.livehtml.cli, would that be better?

Let me know by tomorrow what is the preferred name of the new contrib module. I can change the <friend/> elements accordingly.
Comment 7 David Konecny 2013-06-11 21:49:59 UTC
Friend dependency is OK. The module name I'm not sure what to suggest. I do not think existing web.livehtml and livehtml.cli share anything in common to be merged eventually - web.livehtml records changes done to static HTML in runtime and presents those changes via a "timeline". It's an experimental feature which is Easel unrelated.

> The module provides support for 
> --livehtml 
> command line parameter, thus I used livehtml in its name. 

What is this command line related to? To back2browser? If so I would use that as a base module name, eg. back2browser.cli or back2browser.debugging.
Comment 8 Jaroslav Tulach 2013-06-12 11:43:28 UTC
Would org.netbeans.modules.ko4j.debugging be OK?
Comment 9 David Konecny 2013-06-12 22:43:04 UTC
(In reply to comment #8)
> Would org.netbeans.modules.ko4j.debugging be OK?

That's better. Thanks Jarda.
Comment 10 Jaroslav Tulach 2013-06-13 10:55:57 UTC
ergonomics#84950ad0c9bb
Comment 11 Quality Engineering 2013-06-14 02:00:49 UTC
Integrated into 'main-golden', will be available in build *201306132301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/97f50e72f8f3
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #231067: Adding livehtml module as a friend of Maven so it can provide netbeans.user property to every mvn invocation
Comment 12 Quality Engineering 2013-06-22 02:09:50 UTC
Integrated into 'main-golden', will be available in build *201306212301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/84950ad0c9bb
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #231067: Adding one contrib module as a new friend of few debugging related modules
Comment 13 Quality Engineering 2014-07-22 02:32:59 UTC
Integrated into 'main-silver', will be available in build *201407220001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/363a67c87eac
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: Per request made during #231067 review: renaming to new CNB