This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
In a code review we go through all the files that have been touched in the last commits. We would 'Search History' on SVN and then go through all the file that have been modified. Currently this is really hard, - Many files are there multiple times because of the multiple commits - Rightclickin on a file shows only the possibility for the Diff from one version to the other Expected - After 'Search History' I would click on the revisions that I would like to review - I click 'Open for code review': A new window would open where I would see a Diff of the files that where changed from the revisions I selected and the Files that where commited by me or via the Filter that I select. Product Version = NetBeans IDE 7.3 (Build 201302132200) Operating System = Linux version 3.8.0-23-generic running on amd64 Java; VM; Vendor = 1.7.0_21 Runtime = Java HotSpot(TM) 64-Bit Server VM 23.21-b01
> - I click 'Open for code review': A new window would open where I would see a > Diff of the files that where changed from the revisions I selected and the > Files that where commited by me or via the Filter that I select. I really don't get your proposal. Maybe you should try and make a UI draft of the view. Isn't this btw close to Diff Between Revisions introduced in 7.4 (dev builds)? Select File/Folder, Subversion -> Diff and then select the edge revisions from the combos you want to diff.
I'd like to: 1.) Search History, Filter by '[User Story XXX]' 2.) Goto Summary or Diff 3.) Select the Revisions I want to Diff (eg. 1215-2345) 4.) And the some sort of 'Diff Files View' -> This should open a view over all Files that changed between 1215-2345, maybe sorted by package, or filename that would show me all changes between 1215-2345 to make a proper code review. Obviously Files should only listed once here eg. |Summary| |Diff| [Diff Files] Filter:[Message] contains [UserStory XXX] Rev 1215-2345 |FileName| |Revisions| |User| MyClass1 1215-2345 User1, User5 MyClass2 1256-1270 User2, User3 MyClass3 2344-2345 User1 ---------------------------------------------------------------- [Graphical]|Texutal| | MyClass1 (1215) | MyClass (2345) | | | | | | | currently I only have a list sorted by Revision. Maybe there could be a new action in the Summary/Diff view list, when I first select a list of revisions I want to 'codereview' and then right click on this selection and select the new action 'Diff Files View' or sth like that
(In reply to comment #2) this really looks similar to Subversion -> Diff Revisions feature available in 7.4. Except for the information about users (it's missing there). Could you try and comment it?
They view might look like the one, that would be needed for a codereview, but it misses essential parts. 1.) It needs filtering, like in 'Search History', since a user story usually runs 2-4 weeks. And comments are a good place to mark the commits like '[US 2345]'. And also the Users that worked on the story are important to filter the Diff results. Therefore a mixture between Search History and Diff... would be best!
But as I said before, maybe all that is need is an right click action in Search History 'Diff Files' that will only take the 'selected' items and show the Diff view you where talking about....