This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229272 - No ability to set documentation URL for CC item
Summary: No ability to set documentation URL for CC item
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: CSL (API & infrastructure) (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Petr Hejl
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks: 231992
  Show dependency tree
 
Reported: 2013-05-02 10:37 UTC by Ondrej Brejla
Modified: 2013-09-11 01:41 UTC (History)
4 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
the patch (26.75 KB, patch)
2013-08-28 12:13 UTC, Petr Hejl 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Brejla 2013-05-02 10:37:47 UTC 
GsfCompletionDoc.create() calls new GsfCompletionDoc(controller, elementHandle, null); i.e. documentation URL is ever null...noone can specify it. So "Show documentation in external web browser" button in CC documentation window is ever disabled.

ElementHandle has some UrlHandle implementation, but when one extends it with a proper URL string, GsfCompletionDoc.resolveLink() is never called, so URL button still doesn't work.
Comment 1 Svata Dedic 2013-05-07 18:46:56 UTC 
Enhancement for CSL CC: API redesign :-/ it seems too messy to patch piece by piece.
Comment 2 Ondrej Brejla 2013-05-08 08:18:52 UTC 
Ok, thanks for evaluation.
Comment 3 Petr Hejl 2013-08-28 12:13:08 UTC 
Created attachment 139367 [details]
the patch
Comment 4 Petr Hejl 2013-08-28 12:13:39 UTC 
Please review.
Comment 5 Petr Hejl 2013-09-05 07:47:21 UTC 
Thanks for the review. I'll integrate the change on Monday.
Comment 6 Petr Hejl 2013-09-10 08:07:25 UTC 
Fixed in web-main 806229bd216d.
Comment 7 Quality Engineering 2013-09-11 01:41:40 UTC 
Integrated into 'main-silver', will be available in build *201309110001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/806229bd216d
User: Petr Hejl <phejl@netbeans.org>
Log: #229272 - No ability to set documentation URL for CC item