This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227789 - GlassFish server is missing in Add Server Wizard when J2Ee is disabled
Summary: GlassFish server is missing in Add Server Wizard when J2Ee is disabled
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.3
Hardware: All All
: P1 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 18:57 UTC by TomasKraus
Modified: 2013-03-23 01:58 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Layer XML file with displayName (42.97 KB, text/x-java)
2013-03-21 19:09 UTC, TomasKraus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description TomasKraus 2013-03-21 18:57:17 UTC
testGetAllServerWizardsErgo is failing in ide.ergonomics because GlassFish server is missing in Add Server Wizard when all features (including J2EE) are disabled.

I made temporary hack to hide this issue but this must be fixed ASAP.

This change set should be removed after issue is fixed:
-------------------------------------------------------
changeset:   248717:60ae7be88559
branch:      javaee7
tag:         tip
user:        Tomas Kraus <TomasKraus@netbeans.org>
date:        Thu Mar 21 19:49:40 2013 +0100
summary:     Temporary hack to hide test failures
Comment 1 TomasKraus 2013-03-21 19:09:17 UTC
Created attachment 132921 [details]
Layer XML file with displayName

Here is an output of testGetAllServerWizardsErgo:

INFO [commonserversbase.testGetAllServerWizardsReal]: Iterating full
INFO [commonserversbase.testGetAllServerWizardsReal]: full: Apache Tomcat
INFO [commonserversbase.testGetAllServerWizardsReal]: full: GlassFish Server
INFO [commonserversbase.testGetAllServerWizardsReal]: full: JBoss Application Server
INFO [commonserversbase.testGetAllServerWizardsReal]: full: Oracle WebLogic Server
INFO [commonserversbase.testGetAllServerWizardsReal]: Iteration done for full
INFO [commonserversbase.testGetAllCloudWizardsReal]: Iterating full
INFO [commonserversbase.testGetAllCloudWizardsReal]: full: Amazon Beanstalk
INFO [commonserversbase.testGetAllCloudWizardsReal]: Iteration done for full


INFO [commonserversbase.testGetAllServerWizardsErgo]: Iterating ergo
INFO [commonserversbase.testGetAllServerWizardsErgo]: ergo: Apache Tomcat
INFO [commonserversbase.testGetAllServerWizardsErgo]: ergo: JBoss Application Server
INFO [commonserversbase.testGetAllCloudWizardsErgo]: Iterating ergo
INFO [commonserversbase.testGetAllCloudWizardsErgo]: ergo: Amazon Beanstalk
INFO [commonserversbase.testGetAllCloudWizardsErgo]: Iteration done for ergo 

I was debugging this test and saw that Oracle WebLogic Server is present in ergo run so it's missing just because of exit on assertEquals(name, wizard.getDisplayName()); - my note in my previous mail was wrong.

Attached layer.xml is in javaee7 branch now.

I changed displayName to be hard coded string to make sure something is really there. Did clean/build on both gf common and ergonomics but still can't see glassfish.common in ergonomics output. On the other hand Amazon Beanstalk which uses exactly the same content of Cloud folder seems to work fine.
Comment 2 Petr Hejl 2013-03-22 01:01:18 UTC
I don't have enough patience with this. Fixed in web-main 9ce820c21528. I've also added explicit release version to SDK, though not needed to fix this.

Tools used: editor & debugger.

Tomasi, there might be another issue with GF instance registered by installer being invisible in ergonomics imo. You should definitely check that.

BTW Your attachment is unrelated.
Comment 3 TomasKraus 2013-03-22 10:01:09 UTC
Comment on attachment 132921 [details]
Layer XML file with displayName

<!DOCTYPE filesystem PUBLIC "-//NetBeans//DTD Filesystem 1.2//EN" "http://www.netbeans.org/dtds/filesystem-1_2.dtd">                                                                          
<filesystem>                                                                                   
    <folder name="Actions">                                                                    
        <folder name="GlassFish">                                                              
            <file name="org-netbeans-modules-glassfish-common-actions-ViewAdminConsoleAction.instance"/>                                                                                      
            <file name="org-netbeans-modules-glassfish-common-actions-ViewServerLogAction.instance"/>
            <file name="org-netbeans-modules-glassfish-common-actions-ViewUpdateCenterAction.instance"/>
        </folder>
    </folder>
    <folder name="Servers">
        <file name="GlassfishInstanceProvider.instance">
            <attr name="instanceCreate" methodvalue="org.netbeans.modules.glassfish.common.GlassfishInstanceProvider.getProvider"/>
            <attr name="instanceClass" stringvalue="org.netbeans.modules.glassfish.common.GlassfishInstanceProvider"/>
            <attr name="instanceOf" stringvalue="org.netbeans.spi.server.ServerInstanceProvider"/>
        </file>
        <file name="org-netbeans-modules-glassfish-common-wizards-GlassfishWizardProvider.instance">
            <attr name="instanceCreate" methodvalue="org.netbeans.modules.glassfish.common.wizards.GlassfishWizardProvider.createEe6"/>
            <attr name="instanceClass" stringvalue="org.netbeans.modules.glassfish.common.wizards.GlassfishWizardProvider"/>
            <attr name="instanceOf" stringvalue="org.netbeans.spi.server.ServerWizardProvider"/>
            <attr name="displayName" stringvalue="GlassFish Server"/>
            <!--attr name="displayName" bundlevalue="org.netbeans.modules.glassfish.common.ui.Bundle#GlassFish_Node_Name"/-->
        </file>
    </folder>
</filesystem>
Comment 4 TomasKraus 2013-03-22 12:37:10 UTC
Checked into web-main:javaee7:
------------------------------
changeset:   248718:92ae8b67a6cd
branch:      javaee7
summary:     #227789 - GlassFish server is missing in Add Server Wizard
             when J2Ee is disabled

changeset:   248719:cff2eb60ea52
branch:      javaee7
summary:     #227789 - Temporary hack to hide test failures removed
Comment 5 Quality Engineering 2013-03-23 01:58:47 UTC
Integrated into 'main-golden', will be available in build *201303222300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/9ce820c21528
User: Petr Hejl <phejl@netbeans.org>
Log: #227789 - GlassFish server is missing in Add Server Wizard when J2Ee is disabled