This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227690 - Extend NotificationDisplayer API to provide Category and icon for priority
Summary: Extend NotificationDisplayer API to provide Category and icon for priority
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P2 normal (vote)
Assignee: Jan Peska
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2013-03-20 08:23 UTC by Jan Peska
Modified: 2013-03-27 09:44 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Proposed API changes (33.84 KB, patch)
2013-03-20 10:12 UTC, Jan Peska
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Peska 2013-03-20 08:23:02 UTC
see http://wiki.netbeans.org/UEXNotifications for more details
Comment 1 Jan Peska 2013-03-20 10:12:10 UTC
Created attachment 132824 [details]
Proposed API changes
Comment 2 Jan Peska 2013-03-20 10:28:45 UTC
Please review proposed API changes
Comment 3 Jan Peska 2013-03-25 08:48:31 UTC
I'll integrated the change tomorrow if there won't be any objections.
Comment 4 Stanislav Aubrecht 2013-03-25 12:51:49 UTC
These two new methods don't actually use the category parameter. Is that intentional or just a typo?

    public Notification notify(String title, Icon icon,
            String detailsText, ActionListener detailsAction, Priority priority, Category category) {
        return notify(title, icon, detailsText, detailsAction, priority);
    }


    public Notification notify(String title, Icon icon,
            JComponent balloonDetails, JComponent popupDetails, Priority priority, Category category) {
        return notify(title, icon, balloonDetails, popupDetails, priority);
    }
Comment 5 Jan Peska 2013-03-25 12:57:06 UTC
It is an intention - default implementation ignores newly added category parameter
Comment 6 Jan Peska 2013-03-27 09:39:12 UTC
fix: http://hg.netbeans.org/core-main/rev/15b2175ade50