This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227602 - Occurrences navigation using Alt+Up/Down should be automatically registered when OccurrencesFinder is implemented by a client
Summary: Occurrences navigation using Alt+Up/Down should be automatically registered w...
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: CSL (API & infrastructure) (show other bugs)
Version: 7.3
Hardware: PC Linux
: P3 normal (vote)
Assignee: Svata Dedic
URL:
Keywords:
Depends on: 194356
Blocks:
  Show dependency tree
 
Reported: 2013-03-18 09:19 UTC by Martin Janicek
Modified: 2013-08-06 02:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Janicek 2013-03-18 09:19:59 UTC 
For occurrences navigation each CSL client has to add these lines to the DefaultKeyBindings.xml

<bind actionName="csl-prev-marked-occurrence" key="O-UP"/>
<bind actionName="csl-next-marked-occurrence" key="O-DOWN"/>

..I think this behavior should be implicitly activated if a CSL client implements OccurrencesFinder (and thus we are aware of all occurrences in current file).

BTW: Explicit registration has also another negative impact. If PHP/JS and Groovy registered the same action as above (e.g. csl-next-marked-occurrence) we will see "Navigate to Next Occurrence" in the Options/Keymap several times.
Comment 1 Milutin Kristofic 2013-04-23 13:14:20 UTC 
I added defaultkeybindings.xml to csl. You can remove lines in your client. If it is not supported it will just not work. 

http://hg.netbeans.org/jet-main/rev/e766f0bb3e44
Comment 2 Quality Engineering 2013-04-28 02:18:16 UTC 
Integrated into 'main-golden', will be available in build *201304272301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/e766f0bb3e44
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #227602 - Occurrences navigation using Alt+Up/Down should be automatically registered when OccurrencesFinder is implemented by a client
Comment 3 Martin Janicek 2013-06-14 08:28:27 UTC 
I'm sorry, but the solution don't work for me. I tried to remove both lanes

<bind actionName="csl-prev-marked-occurrence" key="O-UP"/>
<bind actionName="csl-next-marked-occurrence" key="O-DOWN"/>

..in groovy and after doing so the navigation don't work. Do I need to change anything else?
Comment 4 Svata Dedic 2013-08-02 11:58:45 UTC 
Keybinding definition was not referenced from the layer. Fixed in rev http://hg.netbeans.org/jet-main/rev/d87886438dfb.

PHP, Groovy, JS ... please review your keybindings, the mark-next/prev entries could be now removed from your customizations.
Comment 5 Quality Engineering 2013-08-05 02:13:22 UTC 
Integrated into 'main-silver', will be available in build *201308042300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/d87886438dfb
User: Svata Dedic <sdedic@netbeans.org>
Log: #227602: key bindings referened from the layer
Comment 6 Martin Janicek 2013-08-05 11:40:03 UTC 
Thanks Svato! Groovy registration removed in: web-main #884c7cb462a6
Comment 7 Quality Engineering 2013-08-06 02:22:09 UTC 
Integrated into 'main-silver', will be available in build *201308052300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a5e28e758dbf
User: Ondrej Brejla <obrejla@netbeans.org>
Log: #227602 - Occurrences navigation using Alt+Up/Down should be automatically registered when OccurrencesFinder is implemented by a client

Removed useless key bindings.