This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 225528 - Support for Java 7 constant pool entry types
Summary: Support for Java 7 constant pool entry types
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Classfile (show other bugs)
Version: 7.4
Hardware: PC Linux
: P3 normal (vote)
Assignee: apireviews
URL:
Keywords: API, API_REVIEW_FAST
: 234636 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-30 12:54 UTC by Jan Lahoda
Modified: 2013-08-20 12:35 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Proposed API change. (15.73 KB, patch)
2013-02-03 09:24 UTC, Jan Lahoda 		Details | Diff
Updated patch. (24.02 KB, patch)
2013-02-05 12:04 UTC, Jan Lahoda 		Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2013-01-30 12:54:18 UTC 
Java 7 introduced three new types of constant pool entries to support invoke dynamic instruction (InvokeDynamicInfo, MethodHandleInfo, MethodTypeInfo). The classfile library need to support these as well.
Comment 1 Jan Lahoda 2013-02-03 09:24:30 UTC 
Created attachment 130959 [details]
Proposed API change.
Comment 2 Jan Lahoda 2013-02-03 09:26:41 UTC 
Please review, thanks.
Comment 3 Jaroslav Tulach 2013-02-04 17:27:12 UTC 
Y01 I am not sure you want to expose "public enum ReferenceKind" - probably the public keyword should be removed.

Y02 The test could test the result value of toString() otherwise it looks a bit strange.
Comment 4 Tomas Zezula 2013-02-04 17:47:42 UTC 
Agree with Y01. Otherwise OK to me.
Comment 5 Jan Lahoda 2013-02-05 12:04:48 UTC 
Created attachment 131034 [details]
Updated patch.

Y01&Y02: Updated the patch with a getter for the reference kind and updated the test.
Comment 6 Jan Lahoda 2013-02-11 10:20:08 UTC 
If there are not objections, I plan to integrate the change this week.
Comment 7 Jan Lahoda 2013-08-19 06:11:11 UTC 
Done (long time ago).
Comment 8 Jan Lahoda 2013-08-20 12:35:12 UTC 
*** Bug 234636 has been marked as a duplicate of this bug. ***