This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 22533 - "Check out read only" default setting not retained
Summary: "Check out read only" default setting not retained
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Windows 3.1/NT
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
: 30120 30588 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-04-17 12:59 UTC by tkellerer
Modified: 2005-07-19 14:39 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tkellerer 2002-04-17 12:59:08 UTC
This is with NB 3.3.1 and FFJ 4.0 EAP

When I open the advanced dialog for the the CVS
commands (by either holding down the control key
or selecting advanced options) and check the
"Check out Files as Read Only" option, then click
on "Set as default" this setting is not retained
when restarting the IDE. The next time, the option
is unchecked.
Comment 1 Martin Entlicher 2002-04-17 13:11:55 UTC
Thanks for catching this.
The problem must be somewhere in vcsgeneric or vcscore module.
Reassigning...
Comment 2 Marek Grummich 2002-07-22 11:59:11 UTC
Set target milestone to TBD
Comment 3 Jiri Kovalsky 2002-07-22 16:48:35 UTC
This is annoying enough to document it in the Release Notes of
NetBeans 3.4.
Comment 4 Patrick Keegan 2002-08-08 20:42:56 UTC
I slightly reworded this for the release notes. Could you make sure  
that the info is still accurate?:

After setting the Check Out Files as Read Only option as the default 
in the advanced dialog box for CVS commands in a generic VCS 
filesystem, the new default is not retained when the IDE is restarted.
Comment 5 Jiri Kovalsky 2002-08-09 09:44:37 UTC
I think this wording is perfect. :-)
Comment 6 Martin Entlicher 2002-09-10 16:56:18 UTC
Well, currently the default options of commands (both command options
and global options) are not retained when restarting the IDE. The
default options are changed only for the one session, after restart
you get the original defaults.

A mechanism for storing default options needs to be created.
Comment 7 Martin Entlicher 2003-01-15 09:58:42 UTC
*** Issue 30120 has been marked as a duplicate of this issue. ***
Comment 8 Martin Entlicher 2003-01-15 09:59:40 UTC
Scheduled for 4.0 target milestone.
Comment 9 Martin Entlicher 2003-02-03 14:00:01 UTC
*** Issue 30588 has been marked as a duplicate of this issue. ***
Comment 10 andrew 2003-02-28 19:36:07 UTC
The issue is not dangerous, but it is
_very_ annoying in everyday the module using.
I suggest up to P2.
Comment 11 Martin Entlicher 2003-03-01 17:06:46 UTC
Well, this issue is here for quite a long time, mainly because the fix
is not trivial. There is currently no way to simply store the new
default values.

The dialogs are created from a string representation and the new
default values are stored in the created objects. After the restart
the objects are re-created and therefore the new default values are
lost.

It's necessary to create a mechanism for conversion of these objects
back to the String representation and store that string in the
filesystem.

The first step into this direction was made, it's possible to use
toString() method for that purpose:
/cvs/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputComponent.java,v 
<--  VariableInputComponent.java
new revision: 1.6; previous revision: 1.5
done
Checking in
org/netbeans/modules/vcscore/util/VariableInputDescriptor.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDescriptor.java,v 
<--  VariableInputDescriptor.java
new revision: 1.12; previous revision: 1.11

Now it's necessary to pass the updated String to the appropriate
filesystem variable...
Comment 12 Martin Entlicher 2003-03-05 17:37:42 UTC
Fixed in the main trunk:

/cvs/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputComponent.java,v 
<--  VariableInputComponent.java
new revision: 1.7; previous revision: 1.6
/cvs/vcscore/src/org/netbeans/modules/vcscore/commands/CommandCustomizationSupport.java,v 
<--  CommandCustomizationSupport.java
new revision: 1.9; previous revision: 1.8

Comment 13 Martin Entlicher 2003-03-06 09:40:45 UTC
Merged into the release35 branch:

/cvs/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputComponent.java,v 
<--  VariableInputComponent.java
new revision: 1.5.24.2; previous revision: 1.5.24.1
/cvs/vcscore/src/org/netbeans/modules/vcscore/commands/CommandCustomizationSupport.java,v 
<--  CommandCustomizationSupport.java
new revision: 1.7.2.2; previous revision: 1.7.2.1
Comment 14 Jiri Kovalsky 2003-07-16 15:58:22 UTC
Well, there are still other options that are not retained but this one
is, so verifying this issue in NetBeans 3.5.1 build #200307092351.
Comment 15 gregd 2005-03-25 04:33:28 UTC
This is still happening in version 4.0.
Comment 16 Martin Entlicher 2005-03-25 10:49:15 UTC
Right. It looks like this issue was correctly resolved in 3.5, but then it broke
again in either 3.6 or 4.0 - there's issue #42849 and #41425 submitted for that.
However, this is already fixed in 4.1 (see issue #41425).
Comment 17 Peter Pis 2005-07-19 14:39:45 UTC
Verified.
Comment 18 Peter Pis 2005-07-19 14:39:52 UTC
Verified.