This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 224576 - IAE from \r\n in message header using APITokenConnectionAuthenticator
Summary: IAE from \r\n in message header using APITokenConnectionAuthenticator
Status: RESOLVED FIXED
Alias: None
Product: connecteddeveloper
Classification: Unclassified
Component: Hudson (show other bugs)
Version: 7.2
Hardware: PC Linux
: P2 normal (vote)
Assignee: Jaroslav Havlin
URL:
Keywords: NETFIX, SIMPLEFIX
Depends on:
Blocks:
 
Reported: 2013-01-07 16:21 UTC by Jesse Glick
Modified: 2013-01-09 02:27 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Log file excerpt (8.40 KB, text/plain)
2013-01-07 16:21 UTC, Jesse Glick 		Details
Proposed patch (1.55 KB, patch)
2013-01-07 16:23 UTC, Jesse Glick 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2013-01-07 16:21:30 UTC 
Created attachment 129963 [details]
Log file excerpt

Symptom looks similar to bug #209427 but cause is quite different. Connecting to a Jenkins instance using an API token will fail in case the BASIC auth header in Base64 encoding exceeds the default line limit of 76 characters, since the encoded form then gets chunked and the line break is rightly rejected by the HTTP networking layer.
Comment 1 Jesse Glick 2013-01-07 16:23:51 UTC 
Created attachment 129964 [details]
Proposed patch
Comment 2 Jaroslav Havlin 2013-01-07 16:57:47 UTC 
(In reply to comment #1)
> Created attachment 129964 [details]
> Proposed patch
Integrated as http://hg.netbeans.org/core-main/rev/e502d89ae685
Thank you very much, Jesse.
Comment 3 Jesse Glick 2013-01-07 18:52:29 UTC 
Thanks for quick response! As you can see there are several more patches in my queue…

By the way, ‘hg import’ ought to record the original author where it is specified in the patch, as this was.
Comment 4 Jaroslav Havlin 2013-01-08 09:46:41 UTC 
(In reply to comment #3)
> By the way, ‘hg import’ ought to record the original author where it is
> specified in the patch, as this was.
I'm sorry, I was afraid that committing as another user is not allowed.
Other patches should be correct. Thank you for the patches and for help.
Comment 5 Jesse Glick 2013-01-08 19:46:39 UTC 
(In reply to comment #4)
> I was afraid that committing as another user is not allowed.

I think it is conventional if you are just accepting the patch as is. After all, this is very similar to pulling finished changesets from a bundle or a branch. If you edit the patch before committing, then it is better to put your own name on it and credit the original author in the comment where appropriate.

(Git has a distinction between “author” and “committer” for this reason, but Mercurial keeps it simpler.)
Comment 6 Quality Engineering 2013-01-09 02:27:30 UTC 
Integrated into 'main-golden', will be available in build *201301090001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/e502d89ae685
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #224576: IAE from \r\n in message header using APITokenConnectionAuthenticator