This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 222788 - Refactoring results don't push through everywhere
Summary: Refactoring results don't push through everywhere
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P3 normal with 1 vote (vote)
Assignee: Martin Kozeny
URL:
Keywords:
: 151116 189503 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-26 20:31 UTC by java_dev
Modified: 2013-08-21 08:10 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description java_dev 2012-11-26 20:31:19 UTC
Refactoring a directory which is part of a module via:

 rt popup->refactor->rename of directory

does not push through the name change to at least the following files which use the folder name:

1 manifest.mf
2 build.xml
     <project name="name is now wrong"
    <description = description is now wrong


Sorry I  could not locate the refactoring bug-report place to submit this to. It's not so much an IDE / UI issue.
Comment 1 Milos Kleint 2012-12-11 08:48:22 UTC
by directory do you mean the project's own folder? more detailed steps to reproduce would help.
Comment 2 Martin Kozeny 2013-05-28 12:20:08 UTC
It probably means changing package name (codeNameBase), in which is located Bundle.properties does not affect Manifest.mf (OpenIDE-Module attribute and OpenIDE-Module-Localizing-Bundle attribute) and project.xml (tag project and its attribute name and child description tag).
Comment 3 Martin Kozeny 2013-06-13 08:55:20 UTC
Refactoring results are now pushing through manifest and other project's property files.
https://hg.netbeans.org/core-main/rev/87a814de9df8
Comment 4 Quality Engineering 2013-06-15 03:03:02 UTC
Integrated into 'main-golden', will be available in build *201306142301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/87a814de9df8
User: Martin Kozeny <mkozeny@netbeans.org>
Log: #222788: Refactoring results are now pushing through manifest and other project's property files.
Comment 5 Martin Kozeny 2013-06-19 09:11:13 UTC
*** Bug 151116 has been marked as a duplicate of this bug. ***
Comment 6 Jesse Glick 2013-06-19 10:47:08 UTC
I guess the addition of nbbuild/misc/hints-settings.xml was irrelevant to this commit.

Changing the codeNameBase is drastic and should never be done without a proper warning: this will orphan any existing installations of the module and prevent a proper upgrade, not to mention breaking any downstream modules. While this might be appropriate if you have just created a new module and changed your mind about naming, it should never be done on production code.

(Changing the package names inside the module, if they are not exported as APIs, is generally harmless, though you might need to add an entry to META-INF/netbeans/something.here which I forget the exact name of but which lets you change package/class names while preserving deserialization compatibility.)
Comment 7 Martin Kozeny 2013-06-19 10:53:59 UTC
(In reply to comment #6)
> I guess the addition of nbbuild/misc/hints-settings.xml was irrelevant to this
> commit.

You are right, it was removed later from the repository.

> Changing the codeNameBase is drastic and should never be done without a proper
> warning: this will orphan any existing installations of the module and prevent
> a proper upgrade, not to mention breaking any downstream modules. While this
> might be appropriate if you have just created a new module and changed your
> mind about naming, it should never be done on production code.

Maybe the best solution would be to disable renaming of codeNameBase..
 
> (Changing the package names inside the module, if they are not exported as
> APIs, is generally harmless, though you might need to add an entry to
> META-INF/netbeans/something.here which I forget the exact name of but which
> lets you change package/class names while preserving deserialization
> compatibility.)
Comment 8 Martin Kozeny 2013-06-19 10:56:12 UTC
I mean disable renaming package standing for codeNameBase.
Comment 9 Martin Kozeny 2013-08-21 08:10:59 UTC
*** Bug 189503 has been marked as a duplicate of this bug. ***