This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 222446 - Unsaved files window should not be opened when finishing tests
Summary: Unsaved files window should not be opened when finishing tests
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: NB JUnit (show other bugs)
Version: 7.3
Hardware: All All
: P1 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: REGRESSION, T9Y, TEST
Depends on:
Blocks:
 
Reported: 2012-11-20 08:30 UTC by Jiri Skrivanek
Modified: 2013-02-27 08:12 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (23.36 KB, image/png)
2012-11-29 10:15 UTC, soldatov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2012-11-20 08:30:16 UTC
After changes in bug 221034 it is broken the testability hack that running processes/unsaved files window is not shown (http://wiki.netbeans.org/DevFaqNetBeansFullHack). Please, fix it.
Comment 1 Jaroslav Tulach 2012-11-20 10:34:42 UTC
Steps to reproduce?
Comment 2 Jiri Skrivanek 2012-11-20 10:50:09 UTC
To reproduce:
- open jellytools.ide project
- open "Functional Test Packages|org.netbeans.jellytools|EditorOperatorTest.java"
- replace
     return createModuleTest(EditorOperatorTest.class, tests);
by
     return createModuleTest(EditorOperatorTest.class, "testInsert");
- run file
- at the end of test execution you should see the Save window and it bloks until junit timeout expires
Comment 3 Jaroslav Tulach 2012-11-20 12:09:42 UTC
Well, the wiki does not say anything about unsaved objects. The dialog used to be shown even before, as far as I can tell. Just the test was not blocked by the dialog and exited anyway. Now the test waits for proper shutdown.
Comment 4 Jiri Skrivanek 2012-11-20 12:28:16 UTC
Thank you for clarification. I can't tell whether dialog was shown before or not. But as you wrote the test was not blocked and now it is. That is why we noticed the dialog is opened. I think it should not be blocked when netbeans.full.hack=true.
Comment 5 Jaroslav Tulach 2012-11-20 13:32:29 UTC
Some humans run with -Dnetbeans.full.hack=true and they would be in risk of data loss. That is why I am trying to fix this in nbjunit: ergonomics#b987d3846a6e
Comment 6 Jiri Skrivanek 2012-11-22 08:36:16 UTC
Great!!! Thank you for prompt solution. I am eager to verify it in daily build once the fix is propagated to main-silver.
Comment 7 Quality Engineering 2012-11-28 02:35:32 UTC
Integrated into 'main-golden', will be available in build *201211280002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/b987d3846a6e
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #222446: Setting netbeans.close property before the test tries to shutdown the IDE
Comment 8 soldatov 2012-11-29 10:15:33 UTC
Created attachment 128565 [details]
screenshot

in 201211280002 build I see fake (org.netbeans.junit.NbModuleSuite$S$Shutdown.shuttingDown[cnd.editor.CCEditing]) tests
Comment 9 soldatov 2012-11-29 10:18:47 UTC
someone has such problem
Comment 10 Jiri Skrivanek 2012-11-29 10:22:36 UTC
It has connection with bug 221034. I also think it is really confusing. I
recommend to file a new bug for this fake shuttingDown test case.
Anyway I am closing this bug because "unsaved files" problem is resolved.
Comment 11 Quality Engineering 2012-11-30 02:46:26 UTC
Integrated into 'main-golden', will be available in build *201211300001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/984a0ab97f58
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #222446: Setting netbeans.close property before the test tries to shutdown the IDE
(transplanted from b987d3846a6e7a10916b3d96d9ec9c2b68436a39)