This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
This issue was reported manually by dbalek. It already has 1 duplicates Build: NetBeans IDE 7.2 (Build 201207171143) VM: Java HotSpot(TM) Client VM, 22.1-b02, Java(TM) SE Runtime Environment, 1.7.0_03-b05 OS: Windows Vista User Comments: GUEST: running a jsp file Maximum slowness yet reported was 33808 ms, average is 33808
Created attachment 127799 [details] nps snapshot
web.core.WebExecSupport.getFileAndParameters() JSFFrameworkProvider.isInWebModule() 8seconds HibernateFrameworkProvider.isInWebModule() 3 seconds StrutsFrameworkProvider.isInWebModule() Apparently the WES should not run this in EDT. web.core issue - however I cannot find appropriate category in IZ, reassigning to "default owner" :-)
Please pass to appropriate module/person. Thanks.
Martin and Sergey, can you please look at these cases? It's JSF and Struts for Martin, and Hibernate for Sergey. Thanks.
(In reply to comment #4) > Martin and Sergey, can you please look at these cases? It's JSF and Struts for > Martin, and Hibernate for Sergey. Thanks. I agree with Marek (comment #2) that this shouldn't be solved in the framework clients but rather in the code above them - 1, we should count with non-optimalized foreign Web frameworks and 2, it's often not even possible to make calls faster than they are already now - they still need to wait for some actions or have to return wrong values which is in this case undesirable. But the WES.getFileAndParameters() doens't look to me powerful enough too since the invoked action of ActionProvider in UI would still need to wait for finishing that BG action. :/ So I'm afraid that since the users clicks for running particular file, there is not many ways for performance improvements (no time for background precomputation) and that we will have to display some kind of dialog. David, finally all changes I made are in the web.project. Do you want to review them or can I commit into your module? You can take a look on the attached patch. Thanks a lot!
Created attachment 128852 [details] patch for fixing BTW. I forgot to say that the AWT EDT is slowed down above all due to slow native filesystem operations (just the #getBooleanAtributtes() it's about 5,5s in case of JSF). On the other side here is a place for better interaction and behaviour from the IDE.
Martin, the patch looks OK. There is also issue 210214 where I'm thinking of redesigning ActionProvider to have better control what gets execute in the AWT and outside of AWT - at the moment everything runs in AWT which is wrong.
(In reply to comment #7) > Martin, the patch looks OK. Thanks for reviewing. > There is also issue 210214 where I'm thinking of redesigning ActionProvider to > have better control what gets execute in the AWT and outside of AWT - at the > moment everything runs in AWT which is wrong. That's good idea - it would definitely make sense to me. After fixing 210214 probably all actions/targets of ActionProviders will be reviewed whether they could be called outside of the EDT or not. For Run file will be still necessary to wait for the result before the action runs but I guess that these new Runnables can be just moved to the background thread with showing action in the bottom progress bar then - which is actually more user friendly behaviour, so I'm still really fan of #210214. Fixed in web-main #b1449e5d3c26.
Sorry, I wanted to avoid manual merge, final changeset is web-main #2046750f5fc1.
Integrated into 'main-golden', will be available in build *201212070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/2046750f5fc1 User: Martin Fousek <marfous@netbeans.org> Log: #222135 - com.sun.tools.javac.jvm.ClassReader.fillIn: LowPerformance took 33808 ms.
On the base of the conclusion from the issue #226036 I'm reopening this one which becames bug #210214 dependent since I don't see a better way how to fix this slowness without the API change.
This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue. Thanks for your cooperation, NetBeans IDE 8.2 Release Boss