Created attachment 126974 [details]
Flawed module dependencies which were not detected by commit validation
Currently, commit validation checks that non-visible modules must not be orphaned, i.e. there must be a visible module that depends on this non-visible module.
But this check is done on a global per-IDE basis, which is not sufficient: see bug 221083 and the attached deps.txt. In this case, visible module web.kit (enterprise cluster) depends on non-visible module web.client.samples (webcommon cluster), which currently passes commit validation. But it is still incorrect, because after activating the webcommon cluster by ergonomics, the web.client.samples is not activated, which is incorrect and causes bug 221083.
So commit validation should be more strict: it should check that for each non-visible module there is a visible module that depends on it *within the same cluster*.
I don't have time to work on this.