Bug 221321 - Commit validation should detect orphaned modules on a per-cluster basis
Commit validation should detect orphaned modules on a per-cluster basis
Status: NEW
Product: www
Classification: Unclassified
Component: Builds & Repositories
7.3
PC Mac OS X
: P4 (vote)
: TBD
Assigned To: pgebauer
nbre
: TEST
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-02 09:06 UTC by Petr Jiricka
Modified: 2013-01-08 08:48 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
:


Attachments
Flawed module dependencies which were not detected by commit validation (590.24 KB, text/plain)
2012-11-02 09:06 UTC, Petr Jiricka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2012-11-02 09:06:04 UTC
Created attachment 126974 [details]
Flawed module dependencies which were not detected by commit validation

Currently, commit validation checks that non-visible modules must not be orphaned, i.e. there must be a visible module that depends on this non-visible module. 
But this check is done on a global per-IDE basis, which is not sufficient: see bug 221083 and the attached deps.txt. In this case, visible module web.kit (enterprise cluster) depends on non-visible module web.client.samples (webcommon cluster), which currently passes commit validation. But it is still incorrect, because after activating the webcommon cluster by ergonomics, the web.client.samples is not activated, which is incorrect and causes bug 221083.

So commit validation should be more strict: it should check that for each non-visible module there is a visible module that depends on it *within the same cluster*.
Comment 1 Jaroslav Tulach 2012-11-05 13:05:31 UTC
I don't have time to work on this.


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo