This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 218526 - Starup deadlock
Summary: Starup deadlock
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.3
Hardware: PC All
: P1 normal (vote)
Assignee: Vince Kraemer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 10:42 UTC by Petr Hejl
Modified: 2013-01-11 11:47 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
threaddump (26.30 KB, text/plain)
2012-09-18 10:42 UTC, Petr Hejl 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hejl 2012-09-18 10:42:38 UTC 
Created attachment 124504 [details]
threaddump

Another deadlock. Why is the initialization code (CommonServerSupport constructor) touching the server? It makes sense on user action (node expand, deploy) but not on IDE start.
Comment 1 TomasKraus 2012-09-18 17:55:54 UTC 
I don't know. :)

Anyway, there is a small nasty peace of code in CommonServerSupport constructor:
        if (!isRemote) {
            refresh();
        }

There is isReallyRunning() call in refresh which uses remote admin call to check server state.

I'll try to remove it and we'll see how many things will get broken.
Comment 2 TomasKraus 2012-09-19 11:51:58 UTC 
changeset:   232966:c99713155166
summary:     #218526 - Removed (commented out) code causing deadlock. Will remove completely later.

I can't do much more now.
Comment 3 TomasKraus 2012-09-19 15:56:25 UTC 
I made one more change in Keyring access which was causing deadlocks.
Whole properties Map was changed to use own locking and to call Keyring outside this locking.

changeset:   233755:c3072ae1de1f
summary:     #218526 - Removed deadlock conditions in GlassFish instance properties Map

I would like to ask for testing this very well because this change may cause some properties access issues.
Methods values(), keySet() and entrySet() are returning unmodifiable collections because I was unable to handle locking there properly and this may cause some regressions if some code is trying to change map trough them.
Comment 4 Quality Engineering 2012-09-20 02:26:55 UTC 
Integrated into 'main-golden', will be available in build *201209200001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c99713155166
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #218526 - Removed (commented out) code causing deadlock. Will remove completely later.
Comment 5 Quality Engineering 2012-09-21 02:27:59 UTC 
Integrated into 'main-golden', will be available in build *201209210001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c3072ae1de1f
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #218526 - Removed deadlock conditions in GlassFish instance properties Map