Please, evaluate testWriteAccess failures:
ant -f java.kit test-qa-functional -Dtest.includes=**/IDECommitValidationTest*
I suspect prefs.putBoolean("enable.breadcrumbs", true) at org.netbeans.modules.editor.EditorModule.restored(EditorModule.java:274)
Created attachment 124161 [details]
*** Bug 217794 has been marked as a duplicate of this bug. ***
As far as the actual API review goes - I have nothing to add.
On a general note I am surprised breadcrums talk to editor.lib2 via non-public API. I lived under the assumption editor.lib2 is an official API replacement over editor.lib and thus I'd expect the exposes enough functionality for people using editor to eliminate use of editor.lib as well as implementation dependencies.
Integrated into 'main-golden', will be available in build *201209190001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
User: Jan Lahoda <email@example.com>
Log: #217978: enable breadcrumbs through defining a default for AlwaysEnabledAction rather then by setting it enabled
Thanks for the review, integrated.