This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 217501 - (Rename) refactoring keeping CompilationInfos, mostly through Undo queue
Summary: (Rename) refactoring keeping CompilationInfos, mostly through Undo queue
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.3
Hardware: PC Linux
: P2 normal with 1 vote (vote)
Assignee: Ralph Ruijs
URL:
Keywords:
Depends on:
Blocks: 217339
  Show dependency tree
 
Reported: 2012-08-28 07:44 UTC by Jan Lahoda
Modified: 2012-08-29 02:40 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2012-08-28 07:44:41 UTC 
Please see:
http://netbeans.org/bugzilla/show_bug.cgi?id=217339#add_comment

Seems that CompilationInfos are held though AbstractRefactoring, which is held through Undo support (and possibly other roots). Please make sure refactoring is not retaining CompilationInfos outside parsing tasks. One suspicious place is (refactoring.java's) RenameRefactoringPlugin:106.

Thank you very much.
Comment 1 Ralph Ruijs 2012-08-28 08:27:33 UTC 
http://hg.netbeans.org/jet-main/rev/bee8cf016cdc

I removed RenameRefactoringPlugin:106, it was not used anywhere else. Will analyze the heap dump from #217339 to find the other instances as described by: http://netbeans.org/bugzilla/show_bug.cgi?id=217339#c12
Comment 2 Quality Engineering 2012-08-29 02:40:27 UTC 
Integrated into 'main-golden', will be available in build *201208290001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/bee8cf016cdc
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: Issue #217501 - (Rename) refactoring keeping CompilationInfos, mostly through Undo queue