This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 217160 - Install Chrome plugin from the Chrome web store
Summary: Install Chrome plugin from the Chrome web store
Status: VERIFIED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Extbrowser (show other bugs)
Version: 7.3
Hardware: All All
: P2 normal (vote)
Assignee: Denis Anisimov
URL:
Keywords:
Depends on: 217540
Blocks:
  Show dependency tree
 
Reported: 2012-08-21 12:10 UTC by Petr Jiricka
Modified: 2012-09-14 09:32 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2012-08-21 12:10:15 UTC
As discussed in bug 215635, for the NB 7.3 final release (+RC builds), the NetBeans Chrome plugin should be published in the Chrome web store, and the IDE should help with this installation.
Comment 1 Denis Anisimov 2012-08-21 12:33:11 UTC
I would like to distinguish publish plugin action and NB installation request .
This is separate actions. The first one is the plugin owner responsibility :
final plugin version and any subsequent updates are tracked by plugin developer.
Comment 2 Petr Jiricka 2012-08-21 13:07:05 UTC
I agree, but let's worry about that closer to the release date.
Comment 3 Petr Jiricka 2012-09-03 19:55:33 UTC
FYI, there is relevant UI/workflow discussion in comments 13 and 14 of bug 215635#c13.
Comment 4 Tomas Mysik 2012-09-06 03:58:29 UTC
BTW we would need to change the manifest version (to version 2). The current plan is to do it once Beta is out (so users with older Chrome browsers can use our plugin as well). Let me know if we need to fix issue #217540 earlier, I would do that.
Comment 5 Petr Jiricka 2012-09-07 11:32:01 UTC
> Let me know if we need to fix issue #217540 earlier
No need to do that now.

Regarding the UI, the decision from Wednesday's meeting is the following: For production, we’ll provide an alert with the following message and one button that takes the user to the Chrome web store, with the NB extension selected and ready for installation.

"To run your page in Chrome with NetBeans integration, you must first install the NetBeans extension from the Chrome Web Store and then rerun your page."

The label of the button will be "Go to Chrome Web Store".

I know we have some switch that is always turned on in RC+FCS build, and turned off in Dev+Beta builds (or vice versa), so could we use this switch to determine if we will show the current "manual installation prompt" dialog or the "Go to Chrome Web Store" dialog? 
(I must say I don't know what's the name of this switch, does anyone know?)

Comment 6 Tomas Mysik 2012-09-07 11:41:27 UTC
(In reply to comment #5)
> (I must say I don't know what's the name of this switch, does anyone know?)

AFAIK this can be detected via "assert"s.
Comment 7 Petr Jiricka 2012-09-07 16:13:30 UTC
Tonda Nebuzelsky recommended in an offline conversation to introduce our own switch for enabling/disabling the web store installation and not reuse the existing switches. When this switch will not be present at all, then the IDE should use web store. How about netbeans.extbrowser.manual_chrome_plugin_install=true or similar? Tonda will then take care of removing this switch in the RC build.

Denis, could you please implement it this way using some arbitrary plugin (that already exists in Chrome Web Store) so we can try it out? Thanks.
Comment 8 Petr Jiricka 2012-09-07 16:14:16 UTC
> using some arbitrary plugin

... and we will later change it to the real URL once our plugin is uploaded to web store.
Comment 9 Denis Anisimov 2012-09-12 12:57:34 UTC
Let's clarify the suggested UI:
>Regarding the UI, the decision from Wednesday's meeting is the following: For
>production, we’ll provide an alert with the following message and one button
>that takes the user to the Chrome web store, with the NB extension selected and
>ready for installation.
Is it correct that NB alert dialog has to be shown instead of current 
notification dialog; accepting alert dialog should open web page
plugin could be installed from ?

The options are:
- do not show the IDE alert and open "installation" web page right away.
- what web page is subject to open ? Some web page on netbeans.org 
(as we discussed it in the issue #215635) or Google Web store plugin web page ?
- what location should I use in case of netbeans.org page ? Some wiki page or something different ?
Comment 10 Petr Jiricka 2012-09-12 13:45:15 UTC
> Is it correct that NB alert dialog has to be shown instead of current 
> notification dialog; accepting alert dialog should open web page
> plugin could be installed from ?

Yes.

> - do not show the IDE alert and open "installation" web page right away.

Alert dialog in the IDE should be opened.

> - what web page is subject to open ? Some web page on netbeans.org 
> (as we discussed it in the issue #215635) or Google Web store plugin web page ?

Google Web store plugin web page. For now use some random plugin as a placeholder, and later when the NetBeans plugin is uploaded, we can change the URL to the final location.
Comment 11 Denis Anisimov 2012-09-12 13:50:40 UTC
(In reply to comment #10)
> > Is it correct that NB alert dialog has to be shown instead of current 
> > notification dialog; accepting alert dialog should open web page
> > plugin could be installed from ?
> 
> Yes.
> 
> > - do not show the IDE alert and open "installation" web page right away.
> 
> Alert dialog in the IDE should be opened.
> 
> > - what web page is subject to open ? Some web page on netbeans.org 
> > (as we discussed it in the issue #215635) or Google Web store plugin web page ?
> 
> Google Web store plugin web page. For now use some random plugin as a
> placeholder, and later when the NetBeans plugin is uploaded, we can change the
> URL to the final location.

OK, thanks for clarification !
Comment 12 Denis Anisimov 2012-09-12 15:43:34 UTC
Added switch to the ide/launcher/netbeans.conf
 -J-Dnetbeans.extbrowser.manual_chrome_plugin_install=yes

web-main#1371177b92b6
Comment 13 Quality Engineering 2012-09-13 02:14:45 UTC
Integrated into 'main-golden', will be available in build *201209130001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/1371177b92b6
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#217160 - Install Chrome plugin from the Chrome web store
Comment 14 Petr Jiricka 2012-09-14 09:32:28 UTC
Thanks - works fine.