This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 216174 - Syntax highlighting in SQL files confused by multi-line comments
Summary: Syntax highlighting in SQL files confused by multi-line comments
Status: RESOLVED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: SQL Editor (show other bugs)
Version: 7.2
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Jaroslav Havlin
URL:
Keywords: NETFIX
: 218503 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-31 09:26 UTC by vbeffa
Modified: 2012-09-18 18:04 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
proposed patch v1 with unittest (4.32 KB, patch)
2012-07-31 19:12 UTC, matthias42
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vbeffa 2012-07-31 09:26:32 UTC
Entering a multi-line comment in a .sql file like this:

/******************************************************************************
 * comment                                                                    *
 ******************************************************************************/

drop table foo;

create table foo (
    id number
);

causes the remaining code to be colored grey like a comment.
Comment 1 matthias42 2012-07-31 19:12:04 UTC
Created attachment 122600 [details]
proposed patch v1 with unittest

Nice catch! You had to have an even number of stars before the closing slash of the comment to trigger this bug.

The attached patch fixes this and the unitest ensures that it stays that way.

It'll take a netbeans developer to commit the patch to the mercurial repository.
Comment 2 Jaroslav Havlin 2012-08-06 16:18:47 UTC
Patch applied as http://hg.netbeans.org/core-main/rev/9f4801089117

Great job. Thank you very much, Matthias.
Comment 3 Quality Engineering 2012-08-07 02:30:24 UTC
Integrated into 'main-golden', will be available in build *201208070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/9f4801089117
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #216174: Syntax highlighting in SQL files confused by multi-line comments
Comment 4 matthias42 2012-09-18 18:04:35 UTC
*** Bug 218503 has been marked as a duplicate of this bug. ***