This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 215061 - GlassFish 3.1.2.2 not recognized by IDE
Summary: GlassFish 3.1.2.2 not recognized by IDE
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.2
Hardware: All All
: P1 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-02 10:43 UTC by Jiri Skrivanek
Modified: 2012-07-21 13:32 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
incomplete patch (3.14 KB, patch)
2012-07-02 11:14 UTC, Petr Hejl
Details | Diff
a shorter patch (891 bytes, text/plain)
2012-07-02 16:25 UTC, Vince Kraemer
Details
final patch (1.09 KB, text/plain)
2012-07-03 15:12 UTC, Vince Kraemer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2012-07-02 10:43:50 UTC
If you download patch release of GlassFish server, it is not recognized as valid GlassFish server. ServerUtilities.GFV3_VERSION_MATCHER pattern has to be updated to match 3.1.2.2 version. Also "Download Now..." feature offers only 3.1.2. It should be either redirected to patched release or 3.1.2.2 should be added next to 3.1.2. To reproduce:

- download and unzip GlassFish 3.1.2.2
- go to Services view in NetBeans
- right-click Servers and choose "Add Server..."
- select GlassFish and click Next
- check "I have read..." check box
- click "Download Now..." button but you can see only 3.1.2
- cancel dialog
- browse for GlassFish 3.1.2.2 installation folder but it prints "Not a valid GlassFish server installation." and it is not possible to continue

Product Version: NetBeans IDE 7.2 (Build 201206291011)
Java: 1.7.0_06-ea; Java HotSpot(TM) 64-Bit Server VM 23.2-b05
System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb)
Comment 1 Petr Hejl 2012-07-02 11:14:31 UTC
Created attachment 121648 [details]
incomplete patch

This patch solves the registration issue. I don't know the direct download URL and who is responsible for indirect download URL. I'm also not sure about display name.
Comment 2 Petr Hejl 2012-07-02 11:27:03 UTC
Just for the record: To solve this and other potential issues we need the _final_ build of GF and _final_ download location.
Comment 3 Vince Kraemer 2012-07-02 16:25:46 UTC
Created attachment 121664 [details]
a shorter patch

This patch is a bit shorter.  It still doesn't have the corrected fallback download URL... waiting on final decision from GF website folks...
Comment 4 Petr Hejl 2012-07-02 16:35:24 UTC
(In reply to comment #3)
> Created attachment 121664 [details]
> a shorter patch
> 
> This patch is a bit shorter.  It still doesn't have the corrected fallback
> download URL... waiting on final decision from GF website folks...
Nice! Thanks Vince.

Can, you little bit explain direct/indirect URLs? Is the indirect URL (text file on netbeans.org) a place where the updated download location should be placed? I guess we should treat 3.1.2 patch 2 as just a 3.1.2. What is your opinion?

I guess this is what you are trying to make clear in discussion with GF folks. Right?
Comment 5 Vince Kraemer 2012-07-02 16:54:42 UTC
(In reply to comment #4)
> 
> Can, you little bit explain direct/indirect URLs? 

The code for 'download now' uses the following strategy to determine which bits to download:

1. Use the indirect URL (the one pointed to NB.org) to get the partial URL of the download zip file.  NB then creates a complete URL and downloads that zip file.

2. If the first strategy fails because nb.org is down, the complete, hardcoded, url (the direct URL), is used to attempt to download the zip file to support the download now feature.

Peter Williams did the impl on this, since we assumed that there would be situations where the URL to access GF bits would be changed at odd points in the release schedule for NB.

> Is the indirect URL (text
> file on netbeans.org) a place where the updated download location should be
> placed? 

Yes.

>I guess we should treat 3.1.2 patch 2 as just a 3.1.2. What is your
> opinion?

That is my opinion.  Making 3.1.2 and 3.1.2.2 'visible' to users seems bad... especially in NB, since 3.1.2 is so broken.


> 
> I guess this is what you are trying to make clear in discussion with GF folks.
> Right?

yes.
Comment 6 Vince Kraemer 2012-07-03 15:12:27 UTC
Created attachment 121703 [details]
final patch

this should just about do it for code changes.

I will update the content of the indirect URL when the bits for 3.1.2.2 are fully live.  It points to 3.1.2 right now.
Comment 7 Vince Kraemer 2012-07-03 15:40:24 UTC
http://hg.netbeans.org/web-main/rev/2144af0ac5f2
Comment 8 Vince Kraemer 2012-07-03 15:43:22 UTC
please shepherd this through verification and commitment into releases/release72
Comment 9 Quality Engineering 2012-07-04 03:08:39 UTC
Integrated into 'main-golden', will be available in build *201207040002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/2144af0ac5f2
User: vince kraemer <vkraemer@netbeans.org>
Log: #215061: 3.1.2.2 registration and download now support
Comment 10 Jiri Skrivanek 2012-07-04 05:28:19 UTC
Verified with exceptions in dev build 201207040002:
- registration of 3.1.2.2 server works
- direct URL to 3.1.2.2 is not yet valid
- not clear whether version 3.1.2.1-SNAPSHOT (build 3) bundled in installer is final
Comment 11 Petr Hejl 2012-07-07 08:24:40 UTC
Pushed to release72 as 094e5c470ff4.
Comment 12 Quality Engineering 2012-07-10 06:42:48 UTC
Integrated into 'releases', will be available in build *201207092359* or newer. Wait for official and publicly available build.
Changeset: http://hg.netbeans.org/releases/rev/094e5c470ff4
User: vince kraemer <vkraemer@netbeans.org>
Log: #215061: 3.1.2.2 registration and download now support
Comment 13 Jiri Skrivanek 2012-07-10 07:25:44 UTC
Verified in NetBeans IDE 7.2 (Build 201207092359):
- installer contains GlassFish Server Open Source Edition 3.1.2.2 (build 4)
- registration of 3.1.2.2 server works
- direct URL to 3.1.2.2 is not yet valid
Comment 14 ravshansbox 2012-07-19 07:37:08 UTC
It is possible to add server but first you must show folder of glassfish 3.1.2 or prior and netbeans will register it, then just copy to that folder content of glassfish 3.1.2.2, it will just work
Comment 15 Jiri Rechtacek 2012-07-19 09:10:41 UTC
(In reply to comment #14)
> It is possible to add server but first you must show folder of glassfish 3.1.2
> or prior and netbeans will register it, then just copy to that folder content
> of glassfish 3.1.2.2, it will just work

Which build of IDE did you use? (Attach your messages.log is the best) Thanks
Comment 16 mieszczan 2012-07-21 13:32:11 UTC
(In reply to comment #14)
> It is possible to add server but first you must show folder of glassfish 3.1.2
> or prior and netbeans will register it, then just copy to that folder content
> of glassfish 3.1.2.2, it will just work

There is one simpler workaround.
Just change the name of the jar in glassfish installation (c:\glassfish3\glassfish\lib\install\applications\__admingui\WEB-INF\lib\console-core-3.1.2.jar)
Then our server 3.1.2.x will be recognized by the netbeans as version 3.1.2 ;-)
Works fine.