This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 214178 - The navigator for CSL is not refreshed
Summary: The navigator for CSL is not refreshed
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: CSL (API & infrastructure) (show other bugs)
Version: 7.2
Hardware: PC Linux
: P1 normal (vote)
Assignee: Svata Dedic
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2012-06-14 08:52 UTC by Petr Pisl
Modified: 2012-06-25 09:01 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Proposed patch (1.60 KB, patch)
2012-06-14 10:22 UTC, Svata Dedic
Details | Diff
Proposed patch (1.89 KB, patch)
2012-06-14 11:03 UTC, Svata Dedic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Pisl 2012-06-14 08:52:56 UTC
Open a php or html file. Display navigator and make a change in the editor. The navigator is not refreshed. The only way how to refresh navigator is display another file and back to the original.
Comment 1 Svata Dedic 2012-06-14 10:22:27 UTC
Created attachment 120824 [details]
Proposed patch

The patch does 2 things:
1/ initializes arrays for the "update" task. This was forgotten and may lead to NPE

2/ changes condition for including Children of a node to an update. Update of the nodes must be skipped IFF:
- child nodes were never shown (initialized = false)
- they are not initializing or refreshing right now (processing == 0, processing is a nondecreasing variable

please review
Comment 2 Svata Dedic 2012-06-14 11:03:37 UTC
Created attachment 120833 [details]
Proposed patch

Added NPE check if caret is positioned outside all nodes
Comment 3 Petr Pisl 2012-06-14 11:18:51 UTC
I tested the patches and looked through, they are ok for me.
Comment 4 Svata Dedic 2012-06-15 07:07:40 UTC
Fixed in trunk in http://hg.netbeans.org/jet-main/rev/88568e34c779
Comment 5 Quality Engineering 2012-06-17 06:11:22 UTC
Integrated into 'main-golden', will be available in build *201206170001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/88568e34c779
User: Svata Dedic <sdedic@netbeans.org>
Log: #214178: corrected conditions for inclusion of child nodes to update
Comment 6 Vladimir Riha 2012-06-18 10:05:38 UTC
verified in trunk. Navigator reflects changes in html/php file


Product Version: NetBeans IDE Dev (Build 201206180001)
Java: 1.7.0_04; Java HotSpot(TM) Client VM 23.0-b21
System: Linux version 3.0.0-21-generic-pae running on i386; UTF-8; en_US (nb)
Comment 7 Svata Dedic 2012-06-18 11:33:25 UTC
Fixed in trunk
Comment 8 Vladimir Riha 2012-06-18 11:34:14 UTC
v.
Comment 9 Quality Engineering 2012-06-19 02:52:56 UTC
Integrated into 'releases', will be available in build *201206182200* or newer. Wait for official and publicly available build.
Changeset: http://hg.netbeans.org/releases/rev/daea85613037
User: Svata Dedic <sdedic@netbeans.org>
Log: #214178: corrected conditions for inclusion of child nodes to update (transplanted from 88568e34c779)
Comment 10 Tomas Hurka 2012-06-21 18:57:21 UTC
The fix is already in release72 branch
Comment 11 Marian Mirilovic 2012-06-24 20:59:26 UTC
... pending verification in NB 7.2
Comment 12 Vladimir Riha 2012-06-25 09:01:40 UTC
verified in NB 7.2

Product Version: NetBeans IDE 7.2 RC1 (Build 201206242201)
Java: 1.7.0_06-ea; Java HotSpot(TM) Client VM 23.2-b05
System: Linux version 3.0.0-21-generic-pae running on i386; UTF-8; en_US (nb)