This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I have my tomcat 4.0.2 installation configured as follows: Home is c:\Work\tomcat4 which contains bin, classes, common, lib and server subdirectories. Base is c:\Work\tomcat4base which contains conf, logs, webapps and work subdirectories This seems to work fine outside the IDE, but here's what I've encountered when adding it as an external tomcat 4 installation: On the "Add Tomcat 4 Installation" dialog, I click the Browse button and select my home directory. When I click the "Open" button on the file chooser, the error message "Selected Tomcat 4 installation folders are not correct". However, the folder is actually accepted in the field. I took a look at the code in "AddTomcat40Installation.java" and I believe that part of the test for the home directory is locating the server.xml file. In my configuration, the server.xml file is actually located in the base directory which I have not yet entered into the dialog (and I cannot enter it until the home directory is selected). We need to change the test so that this error message does not occur, and we should allow the user to enter the base directory without requiring that the home directory already be selected.
"Selected Tomcat 4 installation folders are not correct" means: you set only HOME with out proper 4 subdirs or server.xml. That is why, the OK is disabled/missing. If you select a PROPER BASE dir, you will see OK button and you will be able to add this external installation into the IDE. If we remove this error message, user will be confused, why s/he can not add some external installation (s/he set only HOME dir with out server.xml, but s/he thinks that everything is OK, but s/he cannot add external installation, because s/he still needs to add correct BASE dir). > we should allow the user to enter > the base directory without > requiring that the home > directory already be selected And how I can guess, where are situated the tomcat binaries? I have to know, where are binaries and server.xml. If server.xml is in the binaries, I need only ti know HOME dir. If server.xml is somewhere else I need to know, where are binaries(HOME dir) and server.xml(BASE dir). Question is, if we should change the error text. Maybe it should be more explanatory.
This should not be closed as "invalid". The current message is not acceptable and needs to be changed. The current behavior is not intuitive. I am reopening. My comment: > we should allow the user to enter the base directory without > requiring that the home directory already be selected This does not mean that we should allow the user to select *only* the base directory, but perhaps in the multi-user situation, it should be posible to enter this directory *first*, but still require that the Home directory be entered. As for the message, I would change it to the following: "The server.xml configuration file was not found in the directory entered. If this Tomcat installation is configured with different Home and Base directories, click OK and then choose the Base directory. Otherwise, click Cancel." The message box should have both OK and Cancel buttons. The OK button would accept the directory entered. The Cancel button would clear the directory entered and redisplay the Home directory file chooser dialog.
text was changed
the fix is known
Set target milestone to TBD
Summary of what is not fixed yet: The message box should have both OK and Cancel buttons. The OK button would accept the directory entered. The Cancel button would clear the directory entered and redisplay the Home directory file chooser dialog.
Fixed in trunk. AddInstallationJPanel rev. 1.10