This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 21322 - mulitple blank lines between wizard steps in contentPane
Summary: mulitple blank lines between wizard steps in contentPane
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Dialogs&Wizards (show other bugs)
Version: 3.x
Hardware: Sun SunOS
: P2 blocker (vote)
Assignee: jrojcek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-03-07 17:50 UTC by _ gordonp
Modified: 2008-12-23 13:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
First patch for release33 (3.54 KB, patch)
2002-03-19 09:33 UTC, David Strupl
Details | Diff
Patch for review (1.45 KB, patch)
2002-03-28 14:37 UTC, jrojcek
Details | Diff
Patch for testing in release33 build. (27.08 KB, application/octet-stream)
2002-03-28 14:39 UTC, jrojcek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description _ gordonp 2002-03-07 17:50:29 UTC
If the text for a wizard step has leading spaces, multiple blank
lines will separate the step from the next. For instance, if the
steps are:

        1. "    step 1"
        2. "    step 2"
        3. "    step 3"

then it will be displayed as:

        step 1



        step 2



        step 3

This causes a severe visual problem (although its only visual) in ifdef's
MakefileWizard. In the MakefileWizard, users create targets. Each new target
is initially displayed as a single step. When the user steps into the target
it is expanded to multiple steps. The expanded steps are indented. For instance,
after the user has specified the creation of a target (but before stepping into
the target panels), the contentPanel looks like:

        . Set Makefile Type
        . Enter Base Directory
        . Enter Makefile Name
        . Create List of Targets       <== current step        . Create Target foo

When the user steps into the "Create Target foo" step, the step expands and
the ``current step'' is the 1st of the expanded steps:

        . Set Makefile Type
        . Enter Base Directory
        . Enter Makefile Name
        . Create List of Targets
        . Create Target foo
        .      Build Output Directory
        .      Enter Source Files
        .      Enter Include Directories

and so on. However, when the indented steps are added I get the weird spacing
I showed above.

I did a test where I made all of my steps have leading spaces and they all had
the same problem, so it isn't related to my adding the expanded steps. It also
isn't garbled text fields as I've verified this by printing out the text from
within the WrappedCellRenderer in my own version of the WizardDescriptor.

This problem has severe usability issues in the MakefileWizard.
Comment 1 David Strupl 2002-03-13 13:40:09 UTC
Hello,
I am marking this as worksforme for now because I was not able to
reproduce the behaviour you are talking about.
What I tried: added space characters to some existing wizards and
watched whether the display is ok or not. And it was.

So in order to fix this bug I need an example of code that
demonstrates the wrong behaviour. Some standalone wizard code would be
cool - if you are not able to provide that please point me to the
source you are having problems with.
Thanks.
Comment 2 _ gordonp 2002-03-13 15:22:33 UTC
Do you have access to the ffj cvs repository? The code is in
the MakefileWizard in the ifdef module. The problem appeared
when we switched from jdk 1.3.1 to jdk 1.4. I've also seen it
with jdk 1.4.1-b04. In all cases this was on Solaris 8 machine
(both sparc and intel).

All you need is the ifdef module from ffj. Its pretty much
separate from the rest of ffj. Once you build and install you
start the MakefileWizard from Build->New Makefile. Press Next
until you get to the "Create List of Targets" panel. Add a name
in the Target Name panel, press Add, and press Next.

When you press the Add button a new step should be shown. If you
entered the name foo then you should see "Create foo". When you
press Next you should see 5 new indented (and multi-spaced) steps
after the Create foo.

This problem is seen 100% of the time in this wizard by every
user (and our SQE department) so I can't imagine you will have
too much trouble duplicating the problem. If you do then please
contact me. This is an important fix for the usability of this
wizard.
Comment 3 David Strupl 2002-03-13 16:03:42 UTC
Yes I have access to Forte Repository. Aha, so the problem is visible
only on JDK1.4? You should have said that in the original report to
save me couple of hours trying to reproduce it (on JDK1.3). I am still
unable to reproduce it with NB3.3.1 or NB3.4(trunk).
I can see the issue while running Forte on JDK1.4 but still have to
investigate whether the problem is in openide or in ifdef.
Comment 4 David Strupl 2002-03-19 09:33:02 UTC
Created attachment 5089 [details]
First patch for release33
Comment 5 David Strupl 2002-03-19 09:40:02 UTC
Jano could you please review my patch? It is definitely not the final
solution since it works fine on JDK1.3 (AFAIK) but on JDK1.4 does not
display the multiline texts.

After spending almost 4 days with this I am inclined to beleive that
replacing the JList usage with single HTML displaying text component
would be better. I suggest to rewrite the implementation for NB3.4.
But maybe it is only that I don't understand JTextArea wrapping
policy. Jano or could you shed some light on the issue? What do you
think about using one HTML rendering component?

Also Marian could we use the patch for release33? 
Comment 6 David Strupl 2002-03-19 09:57:07 UTC
As I am leaving for 3 weeks I am passing the issue to Jano for now. If
you could refine my patch or come with something better please go
ahead and integrate.
Comment 7 jrojcek 2002-03-28 14:37:10 UTC
Created attachment 5225 [details]
Patch for review
Comment 8 jrojcek 2002-03-28 14:39:06 UTC
Created attachment 5226 [details]
Patch for testing in release33 build.
Comment 9 Marian Mirilovic 2002-03-28 14:42:19 UTC
patch verified on Orion 0307 EE.
Comment 10 jrojcek 2002-03-28 14:45:43 UTC
Fix was integrated into the trunk.
Comment 11 _ gordonp 2002-03-28 15:55:46 UTC
I've also verified the patch in Orion 0326
build. Please merge the patch into the orion_fcs
branch so it gets into the orion FCS.
Comment 12 _ ttran 2002-03-29 07:22:00 UTC
marked this bug as fixed because the fix has been integrated into cvs
trunk.

Jano, can you please prepare to commit it into orion_fcs?  Thanks
Comment 13 Marian Mirilovic 2002-04-02 08:59:40 UTC
This issue isn't fixed in [orion_EE](020401_1) !!!
Comment 14 jrojcek 2002-04-03 11:25:37 UTC
Integrated into orion_fcs.
Comment 15 Marian Mirilovic 2002-04-11 09:31:33 UTC
verified in [orion EE](020410_02)
Comment 16 Quality Engineering 2003-07-01 16:26:05 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.