This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 212396 - Same embedded browser reused for webapp and non-webapp uses
Summary: Same embedded browser reused for webapp and non-webapp uses
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Embedded Browser (show other bugs)
Version: 7.2
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: David Konecny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-11 14:57 UTC by Petr Jiricka
Modified: 2012-09-03 13:00 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2012-05-11 14:57:48 UTC
Analogous to bug 208576.
1. Create a new HTML5 application project.
2. Set the browser to embedded webview
3. Run the project - html page will be open in an embedded web browser window
4. In a Java class, display code completion so that the documentation window appears, and press the "Show documentation in external web browser" button

Same window (tab) as was used in step 3 will be reused, it should use a separate one.

David, I am not sure if this worked before your recent changes or not (Denis might know).
Comment 1 David Konecny 2012-05-13 23:28:17 UTC
This area has not been touched for a while so I would think this has always been the case.

I'm not sure it is a good idea to allow multiple instances of embedded browser in the IDE. We should make sure performance and memory consumptions are OK.
Comment 2 Petr Jiricka 2012-05-14 07:49:59 UTC
> I'm not sure it is a good idea to allow multiple instances of embedded browser in the IDE.

I think there should be two, not more (one for webapps, one for everything else). The current UI specification for the embedded browser lists several differences compared to the current state (e.g. the toolbar, or the fact that the webapp preview will by default be opened in the bottom part of the screen only - not the entire editor area), so I think it makes sense to keep the two separate. OTOH I see no reason to have more than 2 (e.g. one browser per project or something like that).
Comment 3 David Konecny 2012-05-15 06:59:57 UTC
Standa could you review this as well please? I had to remove this code which purpose was to reuse existing TopComponent. I have no idea what was the reason for that code in first place.

e8d59d2fb9c0
Comment 4 Quality Engineering 2012-09-03 13:00:54 UTC
Integrated into 'main-golden', will be available in build *201209031048* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/e8d59d2fb9c0
User: David Konecny <dkonecny@netbeans.org>
Log: #212396 - Same embedded browser reused for webapp and non-webapp