This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 211896 - Please update the IDE groovy support (refactoring, goto source, etc) to the latest version of Groovy
Summary: Please update the IDE groovy support (refactoring, goto source, etc) to the l...
Status: NEW
Alias: None
Product: groovy
Classification: Unclassified
Component: Editor (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P2 normal (vote)
Assignee: Martin Janicek
URL:
Keywords:
Depends on: 151987 195271 225401
Blocks:
  Show dependency tree
 
Reported: 2012-05-01 11:35 UTC by netbeansuzr
Modified: 2014-02-10 09:46 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Annonymous inner class in 7.2dev (183.38 KB, image/png)
2012-05-09 13:55 UTC, Martin Janicek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description netbeansuzr 2012-05-01 11:35:54 UTC
The groovy support in the IDE is too old, and as such is not much (if any) better than a standard text editor.  I would really love to use the IDE features while editing groovy code (i'm not using grails just plain groovy).  I use groovy version 1.8 and the IDE features such as refactoring and go to source do not work for this version of Groovy.  In fact the IDE actually identifies certain code block including inner classes as errors, however they work fine when my Groovy scripts are run.

Basically groovy just needs a little attention and and upgrade.

Thanks.
Comment 1 Martin Janicek 2012-05-02 05:24:23 UTC
Hi, thanks for your feedback!

We've already changed the version of Groovy to the latest stable version (which is 1.8.6 at the moment) so this one should be done.

With respect to refactoring, there is already created an issue 151987 pointed to this. Unfortunately it wont be implemented in 7.2 (we are already after feature freeze, so hopefully in the next version right after 7.2).
With respect to the inner class marked as an error. Could you give me an example? (I know that someone already had the same problem and created issue 195271, but I'm not sure if I was able to find the original problem and I have actually never seen error badge when using inner class).

The last point (Goto member) seems to be a valid issue (or maybe an enhancement because it's possible that no-one ever implemented this). I'm going to fill a new issue about that one.
Comment 2 Martin Janicek 2012-05-02 05:32:24 UTC
I'm changing this to the Task type and adding dependencies to the mentioned issue. (I've also created issue 211929 for the Goto source problem)
Comment 3 netbeansuzr 2012-05-09 12:21:36 UTC
Hi, Thanks for your feedback.  

I will try to get you an example of the inner class issue as soon as I get a chance.  

As for the refactoring support, I understand if you are in the middle of a feature freeze but is there any way you could squeeze that in?  I have been waiting for proper groovy support in Netbeans for the last few versions and it hasn't come.  I use groovy quite a bit and would really appreciate that feature in the next release if possible.  

Along these lines, how easy is it to make a custom language refactoring/code completion/goto definition for a custom language.  If it's a matter of adding a text config file and defining some keywords and regular expressions that would be awesome because then we could also add support easily for other languages.  Similar things have been done in other free text editors.
Comment 4 Martin Janicek 2012-05-09 12:44:44 UTC
(In reply to comment #3)
> Hi, Thanks for your feedback.  
> 
> I will try to get you an example of the inner class issue as soon as I get a
> chance.  

Thanks, would be great.

> 
> As for the refactoring support, I understand if you are in the middle of a
> feature freeze but is there any way you could squeeze that in?  

Unfortunately, it's not :(. We really need to make the current development build as stable as possible and thus I can't spend a time on developing new features at the moment. But I definitely plan to work on Groovy support right after the 7.2 will be released, so stay in touch and hopefully it might be done in a few months.

> waiting for proper groovy support in Netbeans for the last few versions and it
> hasn't come.  I use groovy quite a bit and would really appreciate that feature
> in the next release if possible.  

Ye, I'm sorry about that. We didn't have enough of resources and thus we wasn't working on Groovy for a few releases. But it should gets better now ;]

> 
> Along these lines, how easy is it to make a custom language refactoring/code
> completion/goto definition for a custom language.  If it's a matter of adding a
> text config file and defining some keywords and regular expressions that would
> be awesome because then we could also add support easily for other languages. 
> Similar things have been done in other free text editors.

Actually it's not that simple. At least our current infrastructure isn't implemented like that. We do have base module called CSL (Common scripting languages) which is more or less the abstract layer for all those languages like PHP/Groovy/Ruby etc. ..but you still need to implement some APIs to make the language support working. 

Another problem is that some languages (and for example groovy is a great example) aren't as simple to implement, because they are cooperating with some other technology/language (which is Java in this case). And that means refactoring needs to work in a different/nonstandard way - across both languages.
Comment 5 netbeansuzr 2012-05-09 13:11:33 UTC
Thanks again for your quick reply.  I don't blame you about the feature freeze and I understand not having enough resources to work on groovy you don't have to apologize.   I really appreciate all the work you and the rest of the development staff are doing on the NetBeans IDE as a whole.  You have all done an amazing job and I love using the IDE as a whole.  It's really powerful and feature rich.  Keep up the great work.

I took one of my classes where i had the anonymous inner class error (sorry i didn't specify it was an anonymous inner class in my original post) and then made a whole new simplified class which demonstrates the issue (test.groovy):


public class TestClass {

   public void test() {

      Listener l = new Listener() {
         public void doStuff(){ // i get the error on this line in the IDE

         }
      };

   }
}

the error message is: "Unknown type: METHOD_DEF at ..."
Comment 6 Martin Janicek 2012-05-09 13:55:11 UTC
Created attachment 119207 [details]
Annonymous inner class in 7.2dev

Mmm, that's weird. I've just tried to copy/paste into the new Groovy file and no error occurs (attached screenshot as a proof). What version of the NetBeans are you using? (it's possible that I've already fixed it in 7.2 development version and just don't remember that :)
Comment 7 netbeansuzr 2012-05-09 17:14:38 UTC
My apologies, i'm still running 7.1 here.  Likely it was fixed in 7.2.  I should have made separate bugs for updating groovy support and the inner class issue.  I thought they would be related so that's why I didn't bother.  I figured it would have to be addressed when updating groovy anyway.

Product Version: NetBeans IDE 7.1 (Build 201112071828)
Java: 1.6.0_25; Java HotSpot(TM) 64-Bit Server VM 20.0-b11
System: Windows 7 version 6.1 running on amd64; Cp1252; en_CA (nb)
Comment 8 netbeansuzr 2012-07-27 13:41:34 UTC
I have updated to NetBeans 7.2 and was disappointed to find out there there is still no support for goto source and refactoring in groovy files.   I thought this might be a project type setting, but there is no project type for Groovy, only Grails.  As I don't use Grails, I have a Java project with Groovy sources and goto and refactoring do not work.  I can go to java files that are used in my groovy files, but I can't go to groovy code or rename refactor a groovy method for example.

Is there something I'm doing wrong?  If not, can you please release an update to netbeans 7.2 with refactoring and goto support for groovy classes (same as for Java files).

Thanks.
Comment 9 Martin Janicek 2012-07-27 15:03:35 UTC
(In reply to comment #8)
> I have updated to NetBeans 7.2 and was disappointed to find out there there is
> still no support for goto source and refactoring in groovy files.   I thought
> this might be a project type setting, but there is no project type for Groovy,
> only Grails.  As I don't use Grails, I have a Java project with Groovy sources
> and goto and refactoring do not work.  I can go to java files that are used in
> my groovy files, but I can't go to groovy code or rename refactor a groovy
> method for example.
> 
> Is there something I'm doing wrong?  

As I already mentioned in comment 4, it wasn't possible to implement this for NetBeans 7.2. I'm actively working on the groovy refactoring right now.. just stay in touch and follow the Groovy for NetBeans blog[1] and you'll see some news about groovy refactoring immediately when it will be implemented.

> If not, can you please release an update to netbeans 7.2 with refactoring and > > goto support for groovy classes (same as for Java files).

Once the refactoring will be done, you should be able to download the NetBeans daily build where all the features will be available.

[1] https://blogs.oracle.com/netbeansgroovy/
Comment 10 Martin Janicek 2013-03-05 16:37:52 UTC
(In reply to comment #8)
> I have updated to NetBeans 7.2 and was disappointed to find out there there is
> still no support for goto source and refactoring in groovy files.   I thought
> this might be a project type setting, but there is no project type for Groovy,
> only Grails.  As I don't use Grails, I have a Java project with Groovy sources
> and goto and refactoring do not work.  I can go to java files that are used in
> my groovy files, but I can't go to groovy code or rename refactor a groovy
> method for example.

Just in case you didn't notice. About a week or two ago we have just release NetBeans 7.3 which finally contains Groovy refactoring feature. I'm still working on improvements in that area, but in case you are interested in don't hesitate and try it ;)
Any feedback would be welcome, whether positive or negative.
Comment 11 netbeansuzr 2013-07-18 14:29:32 UTC
I have noticed that Netbeans 7.4 beta is available for download so i looked at the changelog and didn't notice any improvements in groovy refactoring support.  It's possible I missed it and if that's the case I apologize.

I have been waiting patiently for better groovy refactoring, find usages and go to source support as currently there are many things it can't do (it's not at the same level as Java support in these areas).  

Can we please get the groovy support improved in Netbeans 7.4 or in a patch that follows right after 7.4 is released?  I don't want to have to wait another few months in the hopes that something will improve in the area of Groovy.

Thanks
Comment 12 alfonso288 2013-10-31 18:43:50 UTC
About the "goto source" issue (sync between navigator and source code): It was working perfectly well in 7.3 and again broken in 7.4 - Is it a netbeans issue or a plugin issue? I know it's free software but with without that function NetBeans is useless. Thanks.
Comment 13 alfonso288 2013-10-31 18:52:23 UTC
(In reply to alfonso288 from comment #12)
> About the "goto source" issue (sync between navigator and source code): It
> was working perfectly well in 7.3 and again broken in 7.4 - Is it a netbeans
> issue or a plugin issue? I know it's free software but with without that
> function NetBeans is useless. Thanks.
Sorry - forgot to say: this is for the Groovy/Grails plugin.
Comment 14 sawadee707 2014-02-10 09:46:49 UTC
NB 7.4 : got the same issue with Grails plugin: "Goto Source not working".
I did "Uninstall" Grails/Groovy plugin - and now it's working. Cheers.