This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Make option to use editor search as in 7.0: press enter - close searchbar, stay on search match press escape (close button) - close searchbar, jump back to start search position change focus to editor - close searchbar start incremantal search with previous search when text selected and then you use search - it finds next instance
Created attachment 117814 [details] search type There will be a search type in options. Some notes in http://wiki.netbeans.org/SearchUseCases I just added SimpleValueName.EDITOR_SEARCH_TYPE, therefore I do fast api review, and plan to push on friday, if no response.
Mito, you must change the "Assigned To" field to apireviews in order to get any feedback from API review team ;-) I agree with the proposed change.
[R01] The editor search type preference is using a string literal. I think this should be changed to a constant, or even better an enum.
Fine to keep the assignee at its normal value; just need to make sure apireviews is on CC so it gets delivered to subscribers of api-changes@netbeans.org. [JG01] Minor I18N issues - some form labels ("Search", "Editor Search Type:") seem to need localization. Also please avoid computed bundle keys like NbBundle.getMessage(GeneralEditorPanel.class, "EST_" + value); safer to explicitly test for known values and load constant keys (or use @Messages). (When time permits, the loc(...) methods should be deleted, letting the form editor manage localized strings in the normal way.)
Created attachment 118048 [details] search type patch 2 [R01] Preferences get and put String literals and also on save remove trailing whitespace uses same approach. I will leave it as it is for now. [JG01] I added localization for labels ("Search", "Editor Search Type:"), thank you for noticing. I rewrite Renderer not to compute strings. if it's fine, I commit and push on 12.4.
http://hg.netbeans.org/jet-main/rev/944e3e87716a
Integrated into 'main-golden', will be available in build *201204130400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/944e3e87716a User: Milutin Kristofic <mkristofic@netbeans.org> Log: #210700 - Editor Search in 7.2 is different than in 7.0
Constant fix http://hg.netbeans.org/jet-main/rev/7800eef726e5
Integrated into 'main-golden', will be available in build *201204170400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/7800eef726e5 User: Milutin Kristofic <mkristofic@netbeans.org> Log: #210700 - Editor Search in 7.2 is different than in 7.0 - constant fix