This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 210593 - netbeans.conf file review
Summary: netbeans.conf file review
Status: RESOLVED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.2
Hardware: PC All
: P4 normal (vote)
Assignee: Antonin Nebuzelsky
URL:
Keywords:
Depends on:
Blocks: 203183
  Show dependency tree
 
Reported: 2012-04-03 08:04 UTC by Libor Fischmeistr
Modified: 2012-06-01 05:26 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Libor Fischmeistr 2012-04-03 08:04:43 UTC 
netbeans.conf file needs review of its content. We got report:

issue 203183 comment 6

And mail from Jesse:
On 03/16/2012 07:25 AM, Libor Fischmeistr wrote:
> details: http://hg.netbeans.org/main-silver/rev/15e12b569faa
> diff --git a/ide/launcher/netbeans.conf b/ide/launcher/netbeans.conf
> +# Be careful when changing jdkhome. There are two launchers - 32-bit and 64-bit.
> +# Which one is used depends on JVM architecture.

Maybe clarify that this is only relevant on Windows.


So its good time to review that file, maybe there will be some other mistakes or obscurities.
Comment 1 Antonin Nebuzelsky 2012-04-06 11:40:08 UTC 
netbeans.conf reviewed and updated in
http://hg.netbeans.org/core-main/rev/b699936d4506

direct link to the file with the update:
http://hg.netbeans.org/core-main/file/b699936d4506/ide/launcher/netbeans.conf

If anyone still sees an unclarity or possible confusion, write a comment here. Thanks.
Comment 2 Quality Engineering 2012-04-07 10:10:07 UTC 
Integrated into 'main-golden', will be available in build *201204070400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/b699936d4506
User: Antonin Nebuzelsky <anebuzelsky@netbeans.org>
Log: #210593: netbeans.conf file review
Comment 3 ulfzibis 2012-04-10 13:59:57 UTC 
IMO the new comment on ${HOME} is still not clear!
"userdir path properties" could refer to three things:
- command line option --userdir
- nested --userdir option in netbeans_default_options
- netbeans_default_userdir
Same for "cachedir path properties".

You generally could clarify, where ${...} variables are valid, in netbeans_default_options, netbeans_default_options nested arguments etc...
Comment 5 ulfzibis 2012-04-10 14:41:39 UTC 
Better use prefix HKCU + enclose in quotes, e.g.:
    "HKCU\Software...."
    'Local AppData' key

IMO, you better should list enumerated like:
Windows replacements:
  ${DEFAULT_USERDIR_ROOT} --> path to "<AppData>/NetBeans"
  ${DEFAULT_CACHEDIR_ROOT} --> path to "<Local AppData>/NetBeans/Cache"
  * using Windows Registry values under
      "HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Shell Folders":
    <AppData> --> user's value of 'AppData' key
    <Local AppData> --> user's value of 'Local AppData' key
Mac replacments:
  ...
Other system's replacements:
  ...
Comment 6 ulfzibis 2012-04-10 15:24:03 UTC 
Oops, no plural, no capital 'C'
(http://netbeans.org/bugzilla/show_bug.cgi?id=196075#c41):

  .... --> path to "<Local AppData>/NetBeans/cache"
Comment 7 Antonin Nebuzelsky 2012-05-31 13:15:45 UTC 
http://hg.netbeans.org/core-main/rev/5c0d0c7c7709
Comment 8 Quality Engineering 2012-06-01 05:26:52 UTC 
Integrated into 'main-golden', will be available in build *201206010001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/5c0d0c7c7709
User: Antonin Nebuzelsky <anebuzelsky@netbeans.org>
Log: #210593: netbeans.conf file review (cont.)