This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 209673 - Provide parent revision in VCSHistoryProvider.HistoryEntry
Summary: Provide parent revision in VCSHistoryProvider.HistoryEntry
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.2
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Assignee: Tomas Stupka
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 208569
  Show dependency tree
 
Reported: 2012-03-16 15:45 UTC by Tomas Stupka
Modified: 2012-04-14 09:45 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
changes o.n.m.versioning (19.83 KB, patch)
2012-03-16 16:03 UTC, Tomas Stupka 		Details | Diff
changes o.n.m.versioning.core (7.40 KB, patch)
2012-03-16 16:04 UTC, Tomas Stupka 		Details | Diff
changes o.n.m.versioning (20.06 KB, patch)
2012-03-29 11:27 UTC, Tomas Stupka 		Details | Diff
changes o.n.m.versioning.core (7.60 KB, patch)
2012-03-29 11:27 UTC, Tomas Stupka 		Details | Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Stupka 2012-03-16 15:45:30 UTC 
In case of some VCS (e.g. Mercurial, Git) it happens that the parent revision to a revision doesn't have to be the time nearest previous revision. 

Because of that, it is necessary for VCSHistoryProvider.HistoryEntry to provide information about its ancestor
Comment 1 Tomas Stupka 2012-03-16 16:03:46 UTC 
Created attachment 116810 [details]
changes o.n.m.versioning
Comment 2 Tomas Stupka 2012-03-16 16:04:10 UTC 
Created attachment 116811 [details]
changes o.n.m.versioning.core
Comment 3 Tomas Stupka 2012-03-16 16:06:06 UTC 
please review
Comment 4 Tomas Stupka 2012-03-22 21:28:24 UTC 
will integrate tomorrow
Comment 5 Jaroslav Tulach 2012-03-26 19:41:59 UTC 
Looks OK.
Comment 6 Tomas Stupka 2012-03-29 11:25:57 UTC 
the suggested patch wouldn't work properly with multifile DO. In such a case a HistoryEntry can contains more files where each can have a different parent.

HistoryEntry.getParentEntry() should also have a file parameter, new patch will follow
Comment 7 Tomas Stupka 2012-03-29 11:27:20 UTC 
Created attachment 117462 [details]
changes o.n.m.versioning
Comment 8 Tomas Stupka 2012-03-29 11:27:47 UTC 
Created attachment 117463 [details]
changes o.n.m.versioning.core
Comment 9 Tomas Stupka 2012-04-11 13:58:03 UTC 
in case no objection is raised i will integrate tomorrow
Comment 10 Tomas Stupka 2012-04-13 10:08:35 UTC 
fixed in core-main #ebf60d27d589
Comment 11 Quality Engineering 2012-04-14 09:45:04 UTC 
Integrated into 'main-golden', will be available in build *201204140400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/ebf60d27d589
User: Tomas Stupka <tstupka@netbeans.org>
Log: Issue #209673 - Provide parent revision in VCSHistoryProvider.HistoryEntry