There are several copies of RetoucheCommit class (e.g. end, php, who else?)
RefactoringCommit class should be sufficient default implementation of Transaction
<summary>Added RefactoringCommit and ModificationResult SPI classes.</summary>
<version major="1" minor="23"/>
<date day="2" month="3" year="2011"/>
Added RefactoringCommit and ModificationResult SPI classes.
<class package="org.netbeans.modules.refactoring.spi" name="ModificationResult"/>
<class package="org.netbeans.modules.refactoring.spi" name="RefactoringCommit"/>
Created attachment 116300 [details]
Created attachment 116301 [details]
Jan, in cnd we also uses ModificationResult.Difference and access it in some places, i.e. DiffElement
which is based on
copy of org.netbeans.modules.refactoring.java.spi.DiffElement
I also plan to move java.spi.DiffElement to refactoring.spi but in different API change...
can you share your ModificationResult variant. Now it keeps internally all changes as collection of Difference, how it is expected to be split?
Created attachment 116305 [details]
Java impl. of ModificationResult
Thanks, I missed that you've proposed MR as interface. OK for me.
Can I double check that introduced RefactoringCommit is the same as mine which is expected to be replaced.
Btw, it's more usual when during api reviews hg diff is attached instead of javadocs :-)
Integrated into 'main-golden', will be available in build *201203210400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
User: Jan Becicka <firstname.lastname@example.org>
Log: #209110: API Addition: RefactoringCommit, Modification Result
Issue #48427 - [60cat] Integrate Refactoring Undo with Editor Undo and Local History
Seems to be integrated a long time ago. Closing.